Skip to content

Conversation

@isturiz
Copy link

@isturiz isturiz commented Dec 9, 2025

Migration from 18 to 19.

Depends on:

Please let me know if any other changes are necessary.

Jairo Llopis and others added 30 commits December 9, 2025 15:58
Really I'm just renaming partner_contact_base.
The new name is more self-explanatory.
This reverts commit e170541.
This reverts commit e170541.
Currently translated at 100,0% (2 of 2 strings)

Translation: partner-contact-10.0/partner-contact-10.0-partner_contact_nationality
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-10-0/partner-contact-10-0-partner_contact_nationality/pt_BR/
Currently translated at 100.0% (2 of 2 strings)

Translation: partner-contact-10.0/partner-contact-10.0-partner_contact_nationality
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-10-0/partner-contact-10-0-partner_contact_nationality/pt/
misern2 and others added 17 commits December 9, 2025 15:58
Currently translated at 100.0% (2 of 2 strings)

Translation: partner-contact-14.0/partner-contact-14.0-partner_contact_nationality
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_contact_nationality/pt_BR/
Currently translated at 100.0% (2 of 2 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_contact_nationality
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_contact_nationality/hr/
Currently translated at 100.0% (2 of 2 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_contact_nationality
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_contact_nationality/es/
Currently translated at 100.0% (2 of 2 strings)

Translation: partner-contact-17.0/partner-contact-17.0-partner_contact_nationality
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_contact_nationality/it/
Currently translated at 100.0% (2 of 2 strings)

Translation: partner-contact-17.0/partner-contact-17.0-partner_contact_nationality
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_contact_nationality/sv/
@legalsylvain
Copy link
Contributor

Could you take a look on red CI ?

@isturiz
Copy link
Author

isturiz commented Dec 9, 2025

Could you take a look on red CI ?

Hi, partner_contact_nationality depends on partner_contact_personal_information_page but this last is not merged yet: #2154

How should we proceed in this case? I'm new to contributing.

@CRogos
Copy link
Contributor

CRogos commented Dec 10, 2025

@isturiz You could add a temporary dependency to this PR: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

The detect unreleased dpendency check will fail, but the tests should be executed and runboat should be available.

test-requirements.txt

odoo-addon-partner_contact_personal_information_page @ git+https://github.com/OCA/partner-contact.git@refs/pull/2154/head#subdirectory=partner_contact_personal_information_page

@isturiz
Copy link
Author

isturiz commented Dec 10, 2025

@isturiz You could add a temporary dependency to this PR: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

I had seen the existence of that file in another PR, but I didn't know the reason. Thanks!

I'll do it in a moment.

@isturiz isturiz changed the title 19.0 mig partner contact nationality [MIG] partner_contact_nationality: Migration to 19.0 Dec 10, 2025
@isturiz isturiz changed the title [MIG] partner_contact_nationality: Migration to 19.0 [MIG][19.0] partner_contact_nationality: Migration to 19.0 Dec 10, 2025
@isturiz isturiz changed the title [MIG][19.0] partner_contact_nationality: Migration to 19.0 [19.0][MIG] partner_contact_nationality: Migration to 19.0 Dec 10, 2025
@isturiz
Copy link
Author

isturiz commented Dec 29, 2025

The depends PR #2154 already was merged; should I make some changes in this PR?

@luisDIXMIT
Copy link

The depends PR #2154 already was merged; should I make some changes in this PR?

Hi @isturiz , maybe the last commit is not longer necessary, i'm not sure.

Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and tested on runboat, LGTM!

@isturiz isturiz force-pushed the 19.0-mig-partner_contact_nationality branch from 00965a8 to 05c6763 Compare January 9, 2026 14:01
@isturiz
Copy link
Author

isturiz commented Jan 9, 2026

The depends PR #2154 already was merged; should I make some changes in this PR?

Hi @isturiz , maybe the last commit is not longer necessary, i'm not sure.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.