-
-
Notifications
You must be signed in to change notification settings - Fork 946
[19.0][MIG] partner_contact_nationality: Migration to 19.0 #2236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
Really I'm just renaming partner_contact_base. The new name is more self-explanatory.
…ersonal_contact_information'
This reverts commit e170541.
…ersonal_contact_information'
This reverts commit e170541.
Currently translated at 100,0% (2 of 2 strings) Translation: partner-contact-10.0/partner-contact-10.0-partner_contact_nationality Translate-URL: https://translation.odoo-community.org/projects/partner-contact-10-0/partner-contact-10-0-partner_contact_nationality/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-10.0/partner-contact-10.0-partner_contact_nationality Translate-URL: https://translation.odoo-community.org/projects/partner-contact-10-0/partner-contact-10-0-partner_contact_nationality/pt/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_contact_nationality Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_contact_nationality/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_contact_nationality Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_contact_nationality/hr/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_contact_nationality Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_contact_nationality/es/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-17.0/partner-contact-17.0-partner_contact_nationality Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_contact_nationality/it/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-17.0/partner-contact-17.0-partner_contact_nationality Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_contact_nationality/sv/
|
Could you take a look on red CI ? |
Hi, How should we proceed in this case? I'm new to contributing. |
|
@isturiz You could add a temporary dependency to this PR: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29 The detect unreleased dpendency check will fail, but the tests should be executed and runboat should be available. test-requirements.txt |
I had seen the existence of that file in another PR, but I didn't know the reason. Thanks! I'll do it in a moment. |
|
The depends PR #2154 already was merged; should I make some changes in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and tested on runboat, LGTM!
00965a8 to
05c6763
Compare
…artner_contact_nationality
Migration from 18 to 19.
Depends on:
Please let me know if any other changes are necessary.