[18.0][MIG] mrp_production_auto_validate: Migration to 18.0 #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on onchange makes this value set only if the BOM is set manually on the Form view, what isn't the case when MO are created by running procurements.
- split values for create in dedicated function - post messages on MO with modified qty - split MOs on create only on procurements
Currently translated at 100.0% (16 of 16 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_production_auto_validate Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_production_auto_validate/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-14.0/manufacture-14.0-mrp_production_auto_validate Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_production_auto_validate/
Currently translated at 100.0% (16 of 16 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_production_auto_validate Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_production_auto_validate/it/
Currently translated at 100.0% (16 of 16 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_production_auto_validate Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_production_auto_validate/it/
Currently translated at 100.0% (16 of 16 strings) Translation: manufacture-14.0/manufacture-14.0-mrp_production_auto_validate Translate-URL: https://translation.odoo-community.org/projects/manufacture-14-0/manufacture-14-0-mrp_production_auto_validate/es/
| "'Order Auto Validation' option." | ||
| ).format(qty=mo.bom_id.product_qty) | ||
|
|
||
| qty_ok = tools.float_is_zero( |
There was a problem hiding this comment.
Why not sticking to float_compare here, like it was before?
The result won't be exactly the same.. with float_compare, both values are rounded and then compared.
With your new suggestion, only their diff is rounded and checked against 0.
e.g.: for the sake of a dumb example, let's assume we are rounding to 0 decimals:
value1: 2.4
value2: 1.6
before:
round(value1) == round(value2)round(2.4) == round(1.6)2 == 2
now:
round(value1 - value2) == 0round(2.4 - 1.6) == 0round(0.8) == 01 == 0
| "The Quantity To Produce of an order is now " | ||
| "restricted to the BoM Quantity." | ||
| ) | ||
| self.mo_auto_validation = False |
There was a problem hiding this comment.
We could take the opportunity to convert this into a computed field with store=True, readonly=False and precompute=True
| role="alert" | ||
| attrs="{'invisible': ['|', ('type', '!=', 'normal'), ('mo_auto_validation', '=', False)]}" | ||
| /> | ||
| invisible="type != 'normal' or mo_auto_validation == False" |
There was a problem hiding this comment.
or not mo_auto_validation
chaule97
force-pushed
the
18.0-mig-mrp_production_auto_validate
branch
from
667df2b to
549d07e
Compare
chaule97
force-pushed
the
18.0-mig-mrp_production_auto_validate
branch
from
549d07e to
f0a2d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mo_auto_validation_warning, we only show the warning<div/>tag whenmo_auto_validation = Truemrp.immediate.production.linewas removed, we have to handlemrp.production.backorderinstead