Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] mrp_package_propagation: Migration to 18.0 #1466

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

grindtildeath
Copy link
Contributor

No description provided.

sebalix and others added 5 commits January 29, 2025 20:07
As there is no quant created for consumable products, Odoo does not
support the propagation of a destination package from an ancestor move to its
destination move. As such, the consumable component move of a MO has no package
to propagate even if the Pre-PICK transfer put one.
To support this use-case, we try to find a package to propagate from ancestor
moves, allowing consumable products to propagate packages.
Copy link

@ajaniszewska-dev ajaniszewska-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG


@api.depends(
"move_raw_ids.propagate_package",
"move_raw_ids.move_line_ids.qty_done",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that seems to fail:
ValueError: Wrong @depends on '_compute_propagated_package_id' (compute method of field mrp.production.propagated_package_id). Dependency field 'qty_done' not found in model stock.move.line.

@grindtildeath grindtildeath force-pushed the 18.0-mig-mrp_package_propagation branch from 9c0fd7d to 0022de7 Compare January 31, 2025 14:05
@grindtildeath grindtildeath force-pushed the 18.0-mig-mrp_package_propagation branch from d30ba9a to adb03c1 Compare February 11, 2025 15:57
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mrp_package_propagation/models/mrp_bom_line.py Outdated Show resolved Hide resolved
mrp_package_propagation/models/mrp_production.py Outdated Show resolved Hide resolved
@grindtildeath grindtildeath force-pushed the 18.0-mig-mrp_package_propagation branch from 1556f40 to bd96ff8 Compare February 12, 2025 14:40
@grindtildeath
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1466-by-grindtildeath-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 892cac3. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 5b91458 into OCA:18.0 Feb 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants