-
-
Notifications
You must be signed in to change notification settings - Fork 16
[18.0][FIX] account_move_delivery_invoice: fix hiding tax column in invoice report #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @yostashiro, @AungKoKoLin1997, |
nobuQuartile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
7208c47 to
c0ea889
Compare
account_move_delivery_invoice/report/report_invoice_document.xml
Outdated
Show resolved
Hide resolved
c0ea889 to
df5403f
Compare
nobuQuartile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Functional review and Code review
yostashiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review.
TIL d-md-table-cell doesn't apply to PDFs.
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 389cbf4. Thanks a lot for contributing to OCA. ❤️ |
Before this fix, the old pre-commit formatting breaks the behavior and the tax column is also hiding in the invoice report.
This PR is to fix the this issue and add the
priorityto make it not override the module behavior by other modules.@qrtl QT6181