Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] Module l10n_br_stock #1776

Merged
merged 33 commits into from
Apr 1, 2022
Merged

Conversation

mbcosta
Copy link
Contributor

@mbcosta mbcosta commented Jan 14, 2022

Migration l10n_br_stock module to v13 #725 .

Migração do modulo l10n_br_stock para a v13, o modulo é bem simples e apenas adiciona os campo Razão Social, CNPJ/CPF e Inscrição Social na Pesquisa da tela de Transferências/stock.picking

image

acredito que se os testes passarem ( provavelmente vão devido a simplicidade do modulo ) vai ser possível o "merge".

cc @renatonlima @rvalyi @marcelsavegnago @mileo

@mbcosta
Copy link
Contributor Author

mbcosta commented Jan 14, 2022

O erro do Travis não parece ter relação com o l10n_br_stock, parece ser referente a uma biblioteca usada pelo l10n_br_fiscal, alguém sabe algo a respeito?

image

@rvalyi rvalyi marked this pull request as draft January 14, 2022 20:17
@marcelsavegnago
Copy link
Member

O erro do Travis não parece ter relação com o l10n_br_stock, parece ser referente a uma biblioteca usada pelo l10n_br_fiscal, alguém sabe algo a respeito?

image

Eu passei por isso.. estou tentando lembrar onde.

@marcelsavegnago
Copy link
Member

@mbcosta #1745 (review)

@mbcosta
Copy link
Contributor Author

mbcosta commented Jan 19, 2022

Obrigado pelo retorno @marcelsavegnago , bom então devido ao problema com a biblioteca PyOpenSSL esse PR depende do #1777

@antoniospneto
Copy link
Contributor

@mbcosta tenta reiniciar o travis pois agora o problema do pyopenssl foi resolvido.

@mbcosta
Copy link
Contributor Author

mbcosta commented Apr 1, 2022

Fala @netosjb , valeu pela saga com o problema do pyopenssl, até gostaria de rodar mas agora o link do Travis está redirecionando para a mudança do runbot para o runboat, amanha vejo de fazer o rebase e ver se vai rodar

image

https://odoo-community.org/blog/the-oca-blog-1/post/goodbye-runbot-welcome-runboat-116

rvalyi and others added 19 commits April 1, 2022 09:34
Signed-off-by: Luis Felipe Mileo <[email protected]>
find . -type f -name '*.py' | xargs sed -i 's/from openerp/from odoo/g'

Signed-off-by: Luis Felipe Mileo <[email protected]>
Signed-off-by: Luis Felipe Mileo <[email protected]>

Signed-off-by: Luis Felipe Mileo <[email protected]>
Signed-off-by: Luis Felipe Mileo <[email protected]>
@mbcosta mbcosta force-pushed the 13.0-mig-l10n_br_stock branch from 032ab25 to 9766269 Compare April 1, 2022 12:37
@mbcosta
Copy link
Contributor Author

mbcosta commented Apr 1, 2022

Rebase feito e PR verde pronto para revisão, valeu @netosjb

@renatonlima renatonlima marked this pull request as ready for review April 1, 2022 13:31
_inherit = "stock.picking"

cnpj_cpf = fields.Char(string="CNPJ/CPF", related="partner_id.cnpj_cpf")
legal_name = fields.Char(string="Razão Social", related="partner_id.legal_name")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seria bom deixar a string em inglês "Legal Name" para ser traduzida


cnpj_cpf = fields.Char(string="CNPJ/CPF", related="partner_id.cnpj_cpf")
legal_name = fields.Char(string="Razão Social", related="partner_id.legal_name")
ie = fields.Char(string="Inscrição Estadual", related="partner_id.inscr_est")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seria bom deixar o campo criado ie que é um related partner_id.inscr_est de ie para inscr_est para manter o mesmo nome do campo no res.parnter

@mbcosta mbcosta force-pushed the 13.0-mig-l10n_br_stock branch from 07ff905 to ea07e4b Compare April 1, 2022 14:03
@mbcosta
Copy link
Contributor Author

mbcosta commented Apr 1, 2022

Alterações feitas @renatonlima

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rvalyi
Copy link
Member

rvalyi commented Apr 1, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-1776-by-rvalyi-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d3da82e into OCA:13.0 Apr 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 494c5d9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants