Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] hr_expense_advance_clearing #284

Open
wants to merge 95 commits into
base: 18.0
Choose a base branch
from

Conversation

Saran440
Copy link
Member

@Saran440 Saran440 commented Jan 14, 2025

@Saran440 Saran440 force-pushed the 18.0-mig-hr_expense_advance_clearing branch 3 times, most recently from f98086a to 06072ae Compare January 16, 2025 04:16
@Saran440
Copy link
Member Author

/ocabot migration hr_expense_advance_clearing

@hitrosol
Copy link

Hi @Saran440 I would like to perform a functional review on this, but the Runboat is not activated. Could you please activate it?

kittiu and others added 21 commits March 14, 2025 10:00
[UPD] Update hr_expense_advance_clearing.pot

[UPD] README.rst
Fix install error when there are already some expense in system.

[UPD] README.rst

hr_expense_advance_clearing 12.0.1.0.1
We should prevent setting the analytic account in expenses used as
employees advance. Otherwise, it can lead to errors charging against an
analytic account that later won't be compensated when all is reconcile.
Anyway, the advance is not an expense, but money of the company moving
from one place to another, that later will be used for real expenses
that will be imputed to the corresponding analytic account
oca-ci and others added 27 commits March 14, 2025 10:00
Currently translated at 100.0% (57 of 57 strings)

Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_clearing
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_clearing/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_advance_clearing
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_advance_clearing/
Currently translated at 100.0% (56 of 56 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_advance_clearing
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_advance_clearing/it/
…company so that the correct property can be retrieved
@Saran440 Saran440 force-pushed the 18.0-mig-hr_expense_advance_clearing branch from a58b027 to f34f81f Compare March 14, 2025 03:00
@Saran440
Copy link
Member Author

@hitrosol I fixed it. please recheck again.

Copy link

@hitrosol hitrosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.
I also try in my local combined with account_reconcile_oca --> OKAY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet