Repository navigation
Conversation
ivantodorovich
left a comment
ivantodorovich
left a comment
There was a problem hiding this comment.
Thanks @imlopes !
I think it might be better for reviewers to split this PR in 3: one per module
| return need_pre_reservation and self.visitor_id | ||
|
|
||
| @api.model_create_multi | ||
| def create(self, vals_list): |
There was a problem hiding this comment.
need unit tests for an e-commerce flow
74f765d to
7da3ca5
Compare
imlopes
changed the title
feed4c3 to
75897a8
Compare
| """Determine reserved, available, reserved but unconfirmed and used seats.""" | ||
| # initialize fields to 0 + compute seats availability | ||
| res = super()._compute_seats() | ||
| counts = dict() |
There was a problem hiding this comment.
This compute method is not covered by tests.
Could we add a test to check the seats_reserved_unconfirmed value?
75897a8 to
0fdb986
Compare
adding translation event_seat_reserve
0fdb986 to
2c23df6
Compare
| if config["test_enable"] and not self.env.context.get( | ||
| "test_event_seat_reserve" | ||
| ): | ||
| _logger.info("Test mode is enabled, you cannot reserve a registration.") | ||
| return True |
There was a problem hiding this comment.
Some tests are failing on the two others PR's because when create a sale, normally the event. registration still on draft state but it's no more the case with these modules. So to avoid failing...
| _inherit = "event.event" | ||
|
|
||
| seats_reserved_unconfirmed = fields.Integer( | ||
| string="Number of Reserved Attendees", |
There was a problem hiding this comment.
| string="Number of Reserved Attendees", | |
| string="Number of Unconfirmed Reserved Attendees", |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
github-actions
Bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
|
superseed by #456 |
Related PR's :
#395
#396