Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] website_sale_cart_clear #893

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[ADD] website_sale_cart_clear #893

wants to merge 2 commits into from

Conversation

SirAionTech
Copy link

No description provided.

@SirAionTech SirAionTech marked this pull request as ready for review January 26, 2024 11:36
@SirAionTech SirAionTech force-pushed the 16.0-add-website_sale_cart_clear branch from 3962314 to f74417d Compare January 26, 2024 11:41
Alber1998
Alber1998 approved these changes Jan 31, 2024
View reviewed changes
Copy link

@Alber1998 Alber1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funtional review LGTM

danielduqma
danielduqma suggested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@danielduqma danielduqma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this module! Please, check my note on widget inheritance

Regards

@danielduqma danielduqma mentioned this pull request Feb 6, 2024
Merged
danielduqma
danielduqma approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@danielduqma danielduqma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, events fixed!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@SirAionTech
Copy link
Author

@OCA/e-commerce-maintainers can someone do the merge thing? Thanks!

@RodrigoBM
Copy link

ping @OCA/e-commerce-maintainers

@SirAionTech
Copy link
Author

@OCA/e-commerce-maintainers this has enough reviews, can someone please merge?

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielduqma danielduqma danielduqma approved these changes

@Alber1998 Alber1998 Alber1998 approved these changes

Assignees
No one assigned
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SirAionTech @OCA-git-bot @RodrigoBM @danielduqma @Alber1998