-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] website_sale_browse_mode #1014
base: 16.0
Are you sure you want to change the base?
[ADD] website_sale_browse_mode #1014
Conversation
a788054
to
fbe060a
Compare
fbe060a
to
4c3ddf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, nice feature and very simple. :)
Some points:
- Not sure if the name is clear enough. Perhaps something like
website_sale_browse_only
orwebsite_sale_disable_shopping
orwebsite_sale_no_shopping
, etc. But maybe it’s just me that did catch directly the meaning. - I think that the case when the cart is not empty when the website shift to "browse only" should be take into account. In such case the user will be able to finish the payment of his/her cart. Maybe button on the cart view should be removed also.
@remytms
|
{ | ||
"name": "Website Sale Browse Only", | ||
"version": "16.0.1.0.0", | ||
"category": "Website", | ||
"author": "Coop IT Easy SC, Odoo Community Association (OCA)", | ||
"website": "https://github.com/OCA/e-commerce", | ||
"license": "AGPL-3", | ||
"depends": ["website_sale_stock"], | ||
"data": [ | ||
"views/website.xml", | ||
"views/res_config_settings.xml", | ||
"views/website_sale_template.xml", | ||
], | ||
"installable": True, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the summary
key is missing (and the installable
key can be removed, as it’s as its default value).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
5605c2e
to
03897a0
Compare
There is an issue with this PR : a banner is added when the website is closed, but it "shifts" the whole website page down, so a part of the footer is no longer visible. As a consequence, visitors cannot change the language when the website is closed. |
internal task : https://gestion.coopiteasy.be/web#id=13307&action=475&active_id=478&model=project.task&view_type=form&menu_id=536