[ADD] website_sale_browse_mode #1014
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-champonnois
force-pushed
the
16.0-add-website_sale_browse_mode
branch
from
a788054 to
fbe060a
Compare
victor-champonnois
force-pushed
the
16.0-add-website_sale_browse_mode
branch
from
fbe060a to
4c3ddf1
Compare
remytms
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Great, nice feature and very simple. :)
Some points:
- Not sure if the name is clear enough. Perhaps something like
website_sale_browse_onlyorwebsite_sale_disable_shoppingorwebsite_sale_no_shopping, etc. But maybe it’s just me that did catch directly the meaning. - I think that the case when the cart is not empty when the website shift to "browse only" should be take into account. In such case the user will be able to finish the payment of his/her cart. Maybe button on the cart view should be removed also.
|
@remytms
|
huguesdk
reviewed
Mar 3, 2025
Comment on lines
1
to
15
| { | ||
| "name": "Website Sale Browse Only", | ||
| "version": "16.0.1.0.0", | ||
| "category": "Website", | ||
| "author": "Coop IT Easy SC, Odoo Community Association (OCA)", | ||
| "website": "https://github.com/OCA/e-commerce", | ||
| "license": "AGPL-3", | ||
| "depends": ["website_sale_stock"], | ||
| "data": [ | ||
| "views/website.xml", | ||
| "views/res_config_settings.xml", | ||
| "views/website_sale_template.xml", | ||
| ], | ||
| "installable": True, | ||
| } |
There was a problem hiding this comment.
the summary key is missing (and the installable key can be removed, as it’s as its default value).
victor-champonnois
force-pushed
the
16.0-add-website_sale_browse_mode
branch
from
5605c2e to
03897a0
Compare
|
There is an issue with this PR : a banner is added when the website is closed, but it "shifts" the whole website page down, so a part of the footer is no longer visible. As a consequence, visitors cannot change the language when the website is closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal task : https://gestion.coopiteasy.be/web#id=13307&action=475&active_id=478&model=project.task&view_type=form&menu_id=536