[17.0][IMP] account_reconcile_oca: Use receivable/payable account on statements with partner as suspense account

[etobella]

With this change, it sets the proper account automatically

[pedrobaeza]

Steps to reproduce the problem?

[etobella]

It was not actually a problem. With the original solution, if I add a new statement.line related to a partner, the suspense account will be the suspense account of the Journal. With the new change, in this case will get the right receivable or payable account of the partner.

It is the behavior we had on 15 and Odoo is promoting on EE

[pedrobaeza]

OK, not sure the gain with this move, but it's not the usual case anyway.

[etobella]

Well, it is how it worked and we lost that functionality from reconcile_widget to account_reconcile_oca. Someone noticed and I made the change because it wasn't too much 😄

[pedrobaeza]

Yeah, now I see:

but it was so insignificant, as that old line doesn't serve for anything if you don't click or manually create a line. What I miss is to have the suspense line as grey to know that "you have to do an action".

[JordiBForgeFlow]

I agree with @pedrobaeza. In enterprise the account stays as suspense account, but from a UI perspective it shows the receivable/payable. Weird.

But it's not a problem to show the suspense account because when reconciling with a line, it will be changed right? Perhaps the issue is when you don't want to reconcile with a line but keep the amount in the default partner receivable/payable account. Then you must remember this account.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[pedrobaeza]

@etobella can you rebase?

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-677-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 59f3a4b. Thanks a lot for contributing to OCA. ❤️