[17.0][FIX] account_reconcile_oca: use the right parameters on views

[xtanuiha]

Steps to Reproduce the Error.

1. Click menu Accounting\Configuration\Accounting\Chart of Accounts
2. Click Reconcile button in list view
3. Raise error below

UncaughtPromiseError > EvalError
Uncaught Promise > Can not evaluate python expression: ([("account_id", "=", id)]) Error: Name 'id' is not defined

[OCA-git-bot]

Hi @etobella,
some modules you are maintaining are being modified, check this out!

[etobella]

When is the error raised? Can you give a step by step explanation please?

[xtanuiha]

When is the error raised? Can you give a step by step explanation please?

Thank you for the feedback. The Pull Request description has been updated to include steps to reproduce the error.

[etobella]

/ocabot rebase

[OCA-git-bot]

Congratulations, PR rebased to 17.0.

[etobella]

Thanks! I see the error. The right way to solve it, would be to edit here
https://github.com/OCA/account-reconcile/blob/17.0/account_reconcile_oca/views/account_account_reconcile.xml#L153

and use the domain [('account_id', '=', active_id)]

[xtanuiha]

Thanks! I see the error. The right way to solve it, would be to edit here https://github.com/OCA/account-reconcile/blob/17.0/account_reconcile_oca/views/account_account_reconcile.xml#L153

and use the domain [('account_id', '=', active_id)]

Thank you for your suggestion, I have corrected the code, please review it.

[etobella]

Great! It looks good. Can you squash your commits in a single one and use a better commit message? For example [FIX] account_reconcile_oca: use the right parameters on views

[xtanuiha]

Great! It looks good. Can you squash your commits in a single one and use a better commit message? For example [FIX] account_reconcile_oca: use the right parameters on views

Squash complete, thanks!

[pedrobaeza]

/ocabot rebase

[etobella]

One question. why the history is weird? I mean, you are commiting as OCA-git-bot?

[pedrobaeza]

He has rebased over an old branch. That's why I launched a rebase from the bot, but it's not working. @sbidoul is the bot stalled?

[OCA-git-bot]

@pedrobaeza The rebase process failed, because command git rebase origin/17.0 failed with output:

First, rewinding head to replay your work on top of it...
Applying: Added translation using Weblate (Italian)
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
CONFLICT (add/add): Merge conflict in account_reconcile_oca/i18n/it.po
Auto-merging account_reconcile_oca/i18n/it.po
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 Added translation using Weblate (Italian)
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

[pedrobaeza]

The rebase + conflict resolution must be done by @xtanuiha

[xtanuiha]

@etobella @pedrobaeza
Ready for merge, thanks!

[pedrobaeza]

I'm afraid not. Now there are 9 commits. You are still doing rebases on old branches. You should fetch first the last content here on OCA. If your OCA remote is origin, and being on the branch of this PR:

git fetch origin 17.0
git rebase origin/17.0
git push -f

[xtanuiha]

I'm afraid not. Now there are 9 commits. You are still doing rebases on old branches. You should fetch first the last content here on OCA. If your OCA remote is origin, and being on the branch of this PR:

git fetch origin 17.0
git rebase origin/17.0
git push -f

Thank you very much for your help! Could you please take a look and confirm if the current status of this PR is correct?

[pedrobaeza]

/ocabot merge minor

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-653-by-pedrobaeza-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 94b9223. Thanks a lot for contributing to OCA. ❤️