-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial version of the mineflayer based npm test #348
Conversation
We COULD change
I'm torn how to best go about this. It seems like a shame to give up on the permission check for |
I had gotten myself confused and thought I was caught up on releases 😃 There is now a new release with the changes: https://github.com/itzg/docker-minecraft-server/releases/tag/2022.6.0 |
Wauw @itzg has our back, so we can do (b) |
incl. adding ONLINE_MODE=FALSE to ./test, as well as removing OPS (as it doesn't seem to work with ONLINE_MODE=FALSE anymore, surprisingly); the idea is to fix this with LuckPerms configuration later.
The idea is to un-comment it later by making Mineflayer use a UID which has this permission through LuckPerms configuration.
This test will fail atm because the server isn't in offline mode
and the
Player
that mineflayer uses doesn't have rights to execute/make
Once these 2 things are fixed this test will pass