Use pyproject.toml, add juju-bin to apps.pluto.plugs, use adopt-info in snapcraft.yaml
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add instructions to connect the interfaces needed by pluto. Fixes: NucciTheBoss#1
jamesbeedy
changed the title
pyproject.toml, add juju-bin to apps.pluto.plugs, use adopt-info in snapcraft.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes address #1 and #3 by, 1) removing
setup.pyin favor ofpyproject.toml, and 2) addingjuju-binplug toapps.pluto.plugs.adopt-infois introduced to automatically set the snap version to the version of theplutocodebase as defined in thepyproject.tomlfile. Additional instructions have been added to theREADME.mdto address connecting the interfaces needed bypluto.