feat(asset): support external video sources with Notion-style rendering #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add display_source handling for video blocks - implement iframe rendering for external video sources - add link_title support in block format - adjust video rendering based on display_source presence
- Introduce new utility functions `setUrlParams` and `deleteUrlParams` - Replace manual URL parameter handling with utility function calls - Update affected components (asset, file, audio) to use new utility
- import deleteUrlParams utility function - modify conditional logic for displaySource handling - clean up URL parameters when displaying source
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
- change const to let for displaySource variable - update displaySource assignment instead of deletion
- Fix typo in `asset.tsx` where `vidoeTitle` was incorrectly spelled
The setUrlParams function was not assigning its result to the source variable in asset, file, and audio components. This change ensures the modified URL with spaceId parameter is properly stored and used in subsequent operations.
This was referenced Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notion Test Page ID
17d00a962bac80728f9fd83e078285d6
Known Issues
Relevant issues:
Solution
Implement rendering using the same method as the Notion website.
Final Result
