Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kabegami dump #5

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

kabegami dump #5

wants to merge 4 commits into from

Conversation

flickowoa
Copy link

No description provided.

@NotAShelf
Copy link
Owner

So, this is still open because I am in a dilemma.

We currently do not make an effort to name the PR'd images, and instead provide numbers for images.
However that's not very intuitive since the user would be required to visit the repo and browse each file or clone and do the same, which I find bothersome.

Two possible approaches to this would be

  1. Move to names instead of numbers, problem solved
  2. Stay with numbers, but provide previews in the README using a github action.

@SrEstegosaurio
Copy link

SrEstegosaurio commented Mar 10, 2024

I think that using names would eventually scale better than providing previews in the README but I feel that if it was to be done then a naming convention would be rather beneficial.

@missrce
Copy link

missrce commented Oct 8, 2024

I think another small issue is that as this repo gets bigger trying to find a wallpaper that fits your resolution will become insanely difficult

@dennkaii
Copy link

Is this ever going to be merged?, i also think names are better in the long run instead of providing a preview in the README.

@kittyandrew
Copy link

bump, i love the idea of the repo, so let me know if any help needed (even for manual renaming work).

@NotAShelf
Copy link
Owner

NotAShelf commented Nov 12, 2024

I'm down to merge this, lots of great wallpapers courtesy of flicko ❤️

Two problems:

  1. 125 new files, we're immediately racking up the file count - larger repo, slower fetches (though you generally only need to fetch when there is a new dump)

Looking to write a bash script to automatically handle renames, if someone wants to PR that in, feel free. Otherwise, I'll take a look myself later.

  1. Harder to find authors since this is a megadump (and we still don't have a proper mechanism to identify authors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants