Upgrade Project to .NET 10 #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erwan-joly
commented
Nov 15, 2025
erwan-joly
commented
- Update target framework from net8.0 to net10.0 in both main and test projects
- Upgrade Entity Framework Core packages from 8.0.6 to 10.0.0
- Upgrade Microsoft.Extensions.DependencyModel from 8.0.0 to 10.0.0
- Upgrade test SDK packages to latest compatible versions
- Update lgtm.yml to use .NET SDK 10.0.100
- Update target framework from net8.0 to net10.0 in both main and test projects - Upgrade Entity Framework Core packages from 8.0.6 to 10.0.0 - Upgrade Microsoft.Extensions.DependencyModel from 8.0.0 to 10.0.0 - Upgrade test SDK packages to latest compatible versions - Update lgtm.yml to use .NET SDK 10.0.100
- Update Microsoft.NET.Test.Sdk from 17.13.0 to 18.0.1 - Update MSTest.TestAdapter from 3.7.0 to 4.0.2 - Update MSTest.TestFramework from 3.7.0 to 4.0.2 - Update Microsoft.Extensions.DependencyModel from 10.0.0 to 9.0.10 (latest stable, 10.0.0 not yet available)
- Update .NET version from 8.0.x to 10.0.x - Update actions/checkout from v2 to v4 - Update actions/setup-dotnet from v3 to v4 - Replace deprecated ::set-output commands with $GITHUB_OUTPUT - Use secrets.GITHUB_TOKEN instead of github.token for consistency
Replace Assert.IsTrue with more specific assertions: - Assert.IsTrue(x == y) → Assert.AreEqual(y, x) - Assert.IsTrue(obj is Type) → Assert.IsInstanceOfType(obj, typeof(Type)) - Assert.IsTrue(!condition) → Assert.IsFalse(condition) This resolves MSTEST0037 warnings introduced in MSTest 4.0.
- Remove CS1591 from NoWarn in project file - Add comprehensive XML documentation to all public types and members: - IDao interfaces with method and parameter descriptions - Dao<TEntity, TDto, TPk> class with constructor and method documentation - ModelBuilderExtensions - InterfaceHelper - ExpressionExtensions - DbContextFindAllExtensions - Use inheritdoc for interface implementations in Dao class This fixes CS1591 warnings properly instead of suppressing them.
Add back CS1591 suppression as XML documentation is not required. The documentation added is still useful but warnings won't fail the build.
Add try-catch blocks when accessing ExportedTypes to handle assemblies that may fail to load their types. This prevents exceptions when iterating through assembly contexts. Also removed unused using directives.
- Change from 10.0.x to explicit '10.0.100' version - Add SDK verification step to debug installation issues
Replace setup-dotnet action with manual installation using the official dotnet-install.sh script. This ensures .NET 10 is available even if GitHub Actions runners don't have it preinstalled yet.
- Serilog: 4.0.0 → 4.3.0 - Moq: 4.20.70 → 4.20.72 All other packages are already at their latest stable versions: - Mapster: 7.4.0 (latest stable) - System.ComponentModel.Annotations: 5.0.0 (latest stable) - Microsoft.Extensions.DependencyModel: 9.0.10 (10.0.0 stable not yet available) - Microsoft.EntityFrameworkCore: 10.0.0 (latest) - Microsoft.NET.Test.Sdk: 18.0.1 (latest) - MSTest packages: 4.0.2 (latest)
- Add AssemblyInfo.cs with Parallelize attribute to fix MSTEST0001 - Replace Assert.AreEqual with Assert.HasCount for collection counts (MSTEST0037) - Replace Assert.AreEqual(0, ...) with Assert.IsEmpty (MSTEST0037) - Add TestingPlatformDotnetTestSupport to project - Add global using for MSTest This fixes all 63 MSTEST0037 errors and the MSTEST0001 error.
MSTest 4.0's Assert.HasCount expects parameters in the order: Assert.HasCount(expectedCount, collection) Previous commit had them reversed which caused 124 compilation errors. This commit swaps all Assert.HasCount parameters to the correct order.
erwan-joly
deleted the
claude/upgrade-dotnet-10-01CEqwkV4kAUCPL96Z6SWFXw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.