Feat/add write support for 91x #491
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsvetelinpetrov
added
doc required
KievDevel
reviewed
Jan 2, 2025
Comment on lines
+264
to
+266
| (programmingOptions.length > 1 && | ||
| !chosenTarget && | ||
| !!mcubootFwPath) |
Contributor
There was a problem hiding this comment.
Looks a bit complex, how this one should be tested? looks like it does overlap with existing mcuboot programming?
Contributor
Author
|
|
KievDevel
reviewed
Apr 10, 2025
|
|
||
| ### Added | ||
|
|
||
| - Write support for 91x |
Contributor
There was a problem hiding this comment.
From Greg:
Suggested change
| - Write support for 91x | |
| - Added support for Nordic Thingy:91 X. Only writing operations are supported, as for other Nordic Thingy devices. |
KievDevel
requested changes
Apr 10, 2025
Contributor
KievDevel
left a comment
KievDevel
left a comment
There was a problem hiding this comment.
REJECTED so we do not merge docs placeholders. Watch NCD-1298
Contributor
|
Put https://nordicsemi.atlassian.net/browse/NCD-1298 to blocked, with attached drafted doc changes. |
greg-fer
reviewed
Nov 27, 2025
| |---------------------|----------|------------|--------------------------|-------------------------------------|--------------------------| | ||
| | nRF9161 DK | nRF9161 | PCA10153 | Yes | No | No | | ||
| | nRF9160 DK | nRF9160 | PCA10090 | Yes | No | No | | ||
| | Nordic Thingy:91 X | nRF9151 | PCA20065 | ??? | ?? | ??? | |
Contributor
There was a problem hiding this comment.
I think you need to rebase... There's an entry for Thingy X since long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nordicsemi.atlassian.net/browse/NCD-1062