Skip to content

fix: Off-by-1 enum terminator value #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidrea
Copy link

It looks like the NRF_MESH_DFU_END_ERROR_BANK_AND_DESTINATION_OVERLAP enum value was added to nrf_mesh_dfu_end_t but the NRF_MESH_DFU_END_ERROR__LAST value not updated.

This should be a pretty benign error as the enum is only statically bounds-checked against the type range, but correcting it protects future runtime boundary checks from spurious errors.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2021

CLA assistant check
All committers have signed the CLA.

@peterhinson
Copy link

@davidrea - good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants