-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update M4AGO scheme to version v1.1.1 (equivalent to dev-1.1.1) #460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmaerz - thanks, looks fine to me.
Betzy is not available, so I can't set up a NorESM2.5 build now (NorESM2.3 should be the same as NorESM2.1). Think it should be fine to merge this, and then deal with a potential problem if it should emerge with NorESM2.5. Or we could just wait a few days until betzy is availabe again.
I think it's fine to have the meson.buid file backwards compatible at this stage. |
Hi Tomas, as summarized in the PR description, I tried a run with the most recent development tag of NorESM. To me, it seemed as if nothing else needed to be changed with respect to |
@jmaerz - Hi, I think it's fine to merge this. The bug in the |
Hi @TomasTorsvik and @JorgSchwinger , with this PR, the M4AGO scheme tag is updated to an improved, updated M4AGO scheme version. For the updated version, see release notes: https://github.com/jmaerz/M4AGO-sinking-scheme/releases/tag/v1.1.0 and https://github.com/jmaerz/M4AGO-sinking-scheme/releases/tag/v1.1.1
Two notes:
Now steps taken to test with the NorESM development tag
noresm2_5_alpha08d
(for documenting the required steps to test branches)In
.gitmodules
, replacedby (Note:
new-m4ago
is just a branch, not a tag)Then, to update the submodules:
After this call, everything should be/was in place to build and run the model as usual. For help on
git fleximod
, see also NorESMhub/NorESM#599 and https://github.com/ESMCI/git-fleximod.However, currently the model version
noresm2_5_alpha08d
fails, when running due to errors that seem not to be related to the updated scheme, but rather due to the ice mesh (see: NorESMhub/NorESM#626).