Skip to content

Fix Circular Reference Issue and Ensure Correct Path for Chromium Build - Without print #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danielfnz wants to merge 1 commit into from
Closed

Fix Circular Reference Issue and Ensure Correct Path for Chromium Build - Without print #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/nopecha/extension/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,24 +53,24 @@ def build(
raise RuntimeError(f"Could not find download link for {branch}")

if outpath.exists():
manifest = loads((outpath / "manifest.json").read_text())
if manifest["version_name"] != latest_release["tag_name"]:
manifest_file = loads((outpath / "manifest.json").read_text())
if manifest_file["version_name"] != latest_release["tag_name"]:
print(
f"[NopeCHA] {latest_release['tag_name']} is available, you got {manifest['version_name']}"
f"[NopeCHA] {latest_release['tag_name']} is available, you got {manifest_file['version_name']}"
)
download_release(download_url, outpath)

else:
print(f"[NopeCHA] Downloading {latest_release['tag_name']}")
download_release(download_url, outpath)

manifest = loads((outpath / "manifest.json").read_text())
manifest["nopecha"].update(manifest)
(outpath / "manifest.json").write_text(dumps(manifest, indent=2))
manifest_file = loads((outpath / "manifest.json").read_text())
manifest_file["nopecha"].update(manifest)
(outpath / "manifest.json").write_text(dumps(manifest_file, indent=2))

print(f"[NopeCHA] Built {branch} extension to {outpath}")

return str(outpath)
return str(outpath.absolute())


def build_chromium(
Expand All @@ -82,4 +82,4 @@ def build_chromium(
def build_firefox(
manifest: typing.Dict[str, typing.Any], outpath: typing.Optional[Path] = None
) -> str:
return build("firefox", manifest, outpath)
return build("firefox", manifest, outpath)