Feat/claim with signature #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odular validation for firebase
… with enhanced validation
There was a problem hiding this comment.
Pull Request Overview
This PR adds new endpoints for domain name registration with signature verification and message hash generation while improving validation and error handling across the gateway service. Key changes include new POST endpoints (/name/register-l2 and /name/register/message) with additional validators, integration of a custom HttpError class and global error middleware, and enhancements to helper functions with updated JSDoc comments.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| clk-gateway/src/index.ts | Added new endpoints for domain registration and message hash generation along with improved error handling. |
| clk-gateway/src/helpers.ts | Updated helper functions with detailed JSDoc comments and restructured imports. |
| clk-gateway/src/types.ts | Introduced the HttpError custom error class for consistent error response handling. |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.