Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: X_df handling in direct approach #468

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: X_df handling in direct approach #468

merged 1 commit into from
Jan 6, 2025

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Jan 6, 2025 •
edited
Loading

Description

Fixes the following:

  • The direct approach required future values of exogenous features for the full horizon, but it only uses the first.
  • The prediction step counter wasn't reset between models, so the second model would get the exogenous features shifted one step forward.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jmoralez jmoralez added the fix label Jan 6, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 6, 2025

CodSpeed Performance Report

Merging #468 will not alter performance

Comparing fix-direct (193787d) with main (1fba842)

Summary

✅ 12 untouched benchmarks

@jmoralez jmoralez marked this pull request as ready for review January 6, 2025 18:19
@jmoralez jmoralez merged commit e09106c into main Jan 6, 2025
26 checks passed
@jmoralez jmoralez deleted the fix-direct branch January 6, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmoralez