Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

littlegptracker: init at unstable-2019-04-14 #91766

Merged
merged 1 commit into from
Sep 23, 2020
Merged

littlegptracker: init at unstable-2019-04-14 #91766

merged 1 commit into from
Sep 23, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jun 29, 2020 •
edited
Loading

Motivation for this change

#81815

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/marvin opt-in
/marvin needs_review

@fgaz fgaz marked this pull request as draft June 29, 2020 14:53
@fgaz
Copy link
Member Author

fgaz commented Jun 29, 2020 •
edited
Loading

Oops, got the prs mixed while waiting for the github downtime to end, this should be a draft for now. Fortunately marvin didn't get triggered.

@fgaz fgaz mentioned this pull request Jun 29, 2020
Open
86 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 29, 2020
@fgaz fgaz mentioned this pull request Jul 31, 2020
Open
@fgaz fgaz force-pushed the littlegptracker/init branch from 4d2c453 to 3c9ba17 Compare August 1, 2020 13:15
@fgaz fgaz marked this pull request as ready for review August 1, 2020 13:25
@fgaz fgaz marked this pull request as draft August 1, 2020 13:25
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Aug 1, 2020
@fgaz fgaz force-pushed the littlegptracker/init branch 5 times, most recently from 81c16dc to e42de70 Compare August 1, 2020 17:58
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 1, 2020
@fgaz fgaz force-pushed the littlegptracker/init branch from e42de70 to 0b4401d Compare August 1, 2020 18:05
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 1, 2020
@fgaz fgaz marked this pull request as ready for review August 1, 2020 19:01
@fgaz fgaz force-pushed the littlegptracker/init branch from 0b4401d to 8bd451b Compare August 1, 2020 19:01
@fgaz
Copy link
Member Author

fgaz commented Aug 1, 2020

Ok, it's ready now

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Aug 1, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 1, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the needs_reviewer (old Marvin label, do not use) label Aug 1, 2020
@fgaz fgaz force-pushed the littlegptracker/init branch from 8bd451b to f3078e2 Compare August 1, 2020 19:09
@marvin-mk2 marvin-mk2 bot added awaiting_merger (old Marvin label, do not use) and removed needs_merger (old Marvin label, do not use) labels Sep 8, 2020
@timokau
Copy link
Member

timokau commented Sep 8, 2020

It looks like this is very sparsely maintained upstream and optimized for mobile devices. Do you think that is an issue / it still belongs into nixpkgs? (I have no idea what a music tracker is, so I'm relying on your opinion.)

@marvin-mk2 marvin-mk2 bot added awaiting_changes (old Marvin label, do not use) and removed awaiting_merger (old Marvin label, do not use) labels Sep 8, 2020
@fgaz
Copy link
Member Author

fgaz commented Sep 8, 2020 •
edited
Loading

and optimized for mobile devices

Well, we have mobile NixOS, don't we? ;)

Yes, it's definitely a more esoteric tracker than milkytracker or soundtracker, but it's still used[1] by some.
There's definitely stuff in #81815 that belongs to an overlay, but I don't think that includes lgpt.
[1]: http://battleofthebits.org/browser/EntryByFormat/lgpt/ (on the left, sort by "when")

Replying to the rest later, I'm on mobile

@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) needs_reviewer (old Marvin label, do not use) and removed awaiting_changes (old Marvin label, do not use) awaiting_reviewer (old Marvin label, do not use) labels Sep 8, 2020
@marvin-mk2 marvin-mk2 bot requested a review from timokau September 13, 2020 22:49
@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Sep 13, 2020
@timokau
Copy link
Member

timokau commented Sep 14, 2020

/status awaiting_changes
Waiting for response to previous review.

@marvin-mk2 marvin-mk2 bot added awaiting_changes (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) labels Sep 14, 2020
@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed awaiting_changes (old Marvin label, do not use) labels Sep 23, 2020
@fgaz fgaz force-pushed the littlegptracker/init branch from ba1b2c2 to e20e2d4 Compare September 23, 2020 17:04
@fgaz fgaz mentioned this pull request Sep 23, 2020
Merged
timokau
timokau requested changes Sep 23, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, you seem motivated enough to get this in so I don't object. Just one tiny nitpick remaining.

pkgs/applications/audio/littlegptracker/default.nix Show resolved Hide resolved
@marvin-mk2 marvin-mk2 bot added awaiting_changes (old Marvin label, do not use) awaiting_reviewer (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) awaiting_changes (old Marvin label, do not use) labels Sep 23, 2020
@timokau timokau merged commit ec3714b into NixOS:master Sep 23, 2020
@fgaz fgaz deleted the littlegptracker/init branch September 23, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turion turion turion left review comments

@OPNA2608 OPNA2608 OPNA2608 requested changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes awaiting_reviewer (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fgaz @turion @OPNA2608 @timokau