Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soundtracker: init at 1.0.0.1 #82057

Merged
merged 1 commit into from
Mar 15, 2020
Merged

soundtracker: init at 1.0.0.1 #82057

merged 1 commit into from
Mar 15, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Mar 8, 2020 •
edited
Loading

Motivation for this change

#81815

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Could someone run a darwin build? From what I can tell it should work

@fgaz fgaz mentioned this pull request Mar 8, 2020
Open
86 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 8, 2020
@veprbl
Copy link
Member

veprbl commented Mar 8, 2020

Could someone run a darwin build?

Currently broken:

clang -DHAVE_CONFIG_H -I. -I..  -DLOCALEDIR=\"/nix/store/5qq22b4cnzlkj8kawllxigccpx6cjbqs-soundtracker-1.0.0.1/share/locale\"   -g -O2 -Wall -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -I/nix/store/mi5nn4652va8x85i6jkklkk9p9s6afns-gtk+-2.24.32-dev/include/gtk-2.0 -I/nix/store/ihkf4wswz6a9szn9c3rncksd4xzxm5vh-gtk+-2.24.32/lib/gtk-2.0/include -I/nix/store/cidsh5xxh4wvl10bgh3crh5kvs0wra75-glib-2.62.5-dev/include -I/nix/store/cidsh5xxh4wvl10bgh3crh5kvs0wra75-glib-2.62.5-dev/include/glib-2.0 -I/nix/store/z3qp77iysv2k6jar5hbsfy9qpwn6697g-glib-2.62.5/lib/glib-2.0/include -I/nix/store/01q8ks4swc8hv7q66i7mb7la411cva5p-cairo-1.16.0-dev/include/cairo -I/nix/store/m87gkyg396lwwjr1c9v9qbf4mkcr527z-freetype-2.10.1-dev/include/freetype2 -I/nix/store/m87gkyg396lwwjr1c9v9qbf4mkcr527z-freetype-2.10.1-dev/include -I/nix/store/lpgdvxzg5jjjfswcpwm85y61wc8r6m0n-pango-1.44.7-dev/include/pango-1.0 -I/nix/store/isnl2dvy12gfpcvz5647gxj4565z7w6q-harfbuzz-2.6.4-dev/include/harfbuzz -I/nix/store/1v28lzjn5zmiz692zcr5v7wrxn2dgcmy-gdk-pixbuf-2.40.0-dev/include/gdk-pixbuf-2.0 -I/nix/store/scdawvy2v3l1r6lfprgd6gxhg2x53i1a-atk-2.34.1-dev/include/atk-1.0 -I/nix/store/z1rirm1xpyr314wzamzwjycy6z404c0g-xorgproto-2019.1/include -I/nix/store/dq7s5gfs8mm9xkdmqydxy68ax2yan89k-libX11-1.6.8-dev/include -I/nix/store/mi5nn4652va8x85i6jkklkk9p9s6afns-gtk+-2.24.32-dev/include/gtk-2.0 -I/nix/store/ihkf4wswz6a9szn9c3rncksd4xzxm5vh-gtk+-2.24.32/lib/gtk-2.0/include -I/nix/store/cidsh5xxh4wvl10bgh3crh5kvs0wra75-glib-2.62.5-dev/include -I/nix/store/cidsh5xxh4wvl10bgh3crh5kvs0wra75-glib-2.62.5-dev/include/glib-2.0 -I/nix/store/z3qp77iysv2k6jar5hbsfy9qpwn6697g-glib-2.62.5/lib/glib-2.0/include -I/nix/store/01q8ks4swc8hv7q66i7mb7la411cva5p-cairo-1.16.0-dev/include/cairo -I/nix/store/m87gkyg396lwwjr1c9v9qbf4mkcr527z-freetype-2.10.1-dev/include/freetype2 -I/nix/store/m87gkyg396lwwjr1c9v9qbf4mkcr527z-freetype-2.10.1-dev/include -I/nix/store/lpgdvxzg5jjjfswcpwm85y61wc8r6m0n-pango-1.44.7-dev/include/pango-1.0 -I/nix/store/isnl2dvy12gfpcvz5647gxj4565z7w6q-harfbuzz-2.6.4-dev/include/harfbuzz -I/nix/store/1v28lzjn5zmiz692zcr5v7wrxn2dgcmy-gdk-pixbuf-2.40.0-dev/include/gdk-pixbuf-2.0 -I/nix/store/scdawvy2v3l1r6lfprgd6gxhg2x53i1a-atk-2.34.1-dev/include/atk-1.0 -I/nix/store/kfyib1jy0pdb9jpl096xgnn1fi3km9d6-goocanvas-1.0.0/include/goocanvas-1.0 -I/nix/store/8k9vgpr0mcgcz4rfzfficl03fw946pjl-jack2-1.9.14/include -I/nix/store/pd0i1bqhpp4wq4gkaggbp1rds2vk7d7n-SDL-1.2.15-dev/include/SDL -I/nix/store/pd0i1bqhpp4wq4gkaggbp1rds2vk7d7n-SDL-1.2.15-dev/include/SDL -I/nix/store/pd0i1bqhpp4wq4gkaggbp1rds2vk7d7n-SDL-1.2.15-dev/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE -c -o keys.o keys.c
keys.c:38:10: fatal error: 'gdk/gdkx.h' file not found
#include <gdk/gdkx.h>
         ^~~~~~~~~~~~
1 error generated.
make[3]: *** [Makefile:536: keys.o] Error 1
make[3]: Leaving directory '/private/var/folders/1f/2mj_ng1n2y3_wc59fgw3fn_r0000gn/T/nix-build-soundtracker-1.0.0.1.drv-0/soundtracker-1.0.0.1/app'
make[2]: *** [Makefile:552: all-recursive] Error 1
make[2]: Leaving directory '/private/var/folders/1f/2mj_ng1n2y3_wc59fgw3fn_r0000gn/T/nix-build-soundtracker-1.0.0.1.drv-0/soundtracker-1.0.0.1/app'
make[1]: *** [Makefile:623: all-recursive] Error 1
make[1]: Leaving directory '/private/var/folders/1f/2mj_ng1n2y3_wc59fgw3fn_r0000gn/T/nix-build-soundtracker-1.0.0.1.drv-0/soundtracker-1.0.0.1'
make: *** [Makefile:402: all] Error 2

doronbehar
doronbehar requested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine for me (on NixOS).

pkgs/applications/audio/soundtracker/default.nix Outdated Show resolved Hide resolved
@fgaz fgaz force-pushed the soundtracker/init branch from 4651c1b to 1993626 Compare March 13, 2020 12:55
@fgaz
Copy link
Member Author

fgaz commented Mar 13, 2020

Thank you @veprbl. I have no idea why that would happen (the -I is there), so I marked it as broken for darwin.

@fgaz fgaz force-pushed the soundtracker/init branch from 1993626 to 2c826cc Compare March 15, 2020 10:00
doronbehar
doronbehar approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@veprbl veprbl merged commit f241aa6 into NixOS:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgaz @veprbl @doronbehar