Skip to content

installShellFiles: add PowerShell completion support#506501

Open
lafrenierejm wants to merge 2 commits intoNixOS:stagingfrom
lafrenierejm:installShellFiles-powershell
Open

installShellFiles: add PowerShell completion support#506501
lafrenierejm wants to merge 2 commits intoNixOS:stagingfrom
lafrenierejm:installShellFiles-powershell

Conversation

@lafrenierejm
Copy link
Copy Markdown
Contributor

@lafrenierejm lafrenierejm commented Apr 4, 2026

As requested in #384084, adds --powershell flag to installShellCompletion. This installs completions to $out/share/powershell/ with synthesized names of the form $cmd.Completion.ps1 when using --cmd.

Updated the tea package to use this new flag.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@lafrenierejm lafrenierejm changed the base branch from master to staging April 4, 2026 05:12
@nixpkgs-ci nixpkgs-ci bot closed this Apr 4, 2026
@nixpkgs-ci nixpkgs-ci bot reopened this Apr 4, 2026
github-actions[bot]

This comment was marked as outdated.

Sign in to view

@lafrenierejm
installShellFiles: add PowerShell completion support
04535d4 
Add --powershell flag to installShellCompletion, which installs completions to
$out/share/powershell/ with synthesized names of the form $cmd.Completion.ps1
when using --cmd.

This feature was requested in NixOS#384084.
@lafrenierejm
tea: use installShellFiles for PowerShell completion
20af58e
@lafrenierejm lafrenierejm force-pushed the installShellFiles-powershell branch from 55590b1 to 20af58e Compare April 4, 2026 05:16
@github-actions github-actions bot dismissed their stale review April 4, 2026 05:16

Review dismissed automatically

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@j4m3s-s j4m3s-s Awaiting requested review from j4m3s-s

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lafrenierejm