Skip to content

coreutils: fix cygwin build #476294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdaniels5757 merged 1 commit into from
Jan 2, 2026
Merged

coreutils: fix cygwin build #476294

mdaniels5757 merged 1 commit into from
Jan 2, 2026

Conversation

@corngood
Copy link
Contributor

@corngood corngood commented Jan 2, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@corngood corngood mentioned this pull request Jan 2, 2026
Draft
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jan 2, 2026
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jan 2, 2026
@mdaniels5757
Copy link
Member

mdaniels5757 commented Jan 2, 2026

Have you built/tested this on cygwin?

@corngood
Copy link
Contributor Author

corngood commented Jan 2, 2026

Have you built/tested this on cygwin?

Yep. It needs #468206, but then pkgsCross.x86_64-cygwin.coreutils should build.

@mdaniels5757 mdaniels5757 added this pull request to the merge queue Jan 2, 2026
Merged via the queue into NixOS:master with commit 63688d9 Jan 2, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 Awaiting requested review from mdaniels5757

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@corngood @mdaniels5757