[Backport release-25.11] fix inputDerivation in case of __structuredAttrs #470487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: infinisil <[email protected]> (cherry picked from commit 23644a2)
Setting allowedReferences to null seems to only work as a fluke. It doesn't work with outputChecks, and I couldn't get it to work at all when declaring my own derivation manually (I'm honestly still unsure why it works at all as-is in inputDerivation) In any case, Rather than setting allowedReferences etc to values that mimic the default behaviour, we can remove those attributes to get the default behaviour. (cherry picked from commit 04c3ba5)
Co-authored-by: infinisil <[email protected]> !fixup every test needs a meta field? !fixup refactor inputDerivation tests !fixup fix tests (cherry picked from commit 97c3645)
13 tasks
Ericson2314
approved these changes
Dec 13, 2025
nixpkgs-ci
bot
requested review from
Artturin,
Ericson2314,
RossComputerGuy,
emilazy,
philiptaron and
reckenrode
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-25.11, triggered by a label in #469652.Before merging, ensure that this backport is acceptable for the release.
Even as a non-committer, if you find that it is not acceptable, leave a comment.
Tip
If you maintain all packages touched by this pull request, and they are all located under
pkgs/by-name/*, you can comment@NixOS/nixpkgs-merge-bot mergeto automatically merge this PR using thenixpkgs-merge-bot.