-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
nix: fix cygwin build #467538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix: fix cygwin build #467538
Conversation
|
@ofborg build pkgsCross.x86_64-cygwin.nix |
|
Very excited about this! @alyssais how would you like the changes to be merged (preemptively create many PRs? Split out dynamically based on what needs more review?) I am hoping that these changes can be merged soon (because I am very excited by @corngood's work!) and also backported to 25.11, because I would like to use this in Nix's own CI to make sure we don't have Cygwin regressions. Per it being draft, there is still some cleanup to be done to the stuff (my comments below are premature, @corngood is already aware of many of those things) but @corngood was wondering about what sort of approach to PR bucketting he should use (as he cleans up and gets ready to submit non-draft PRs) and so I am relaying that question to you. |
In my experience doing musl, the fastest way to get something like this through review and merged is:
|
It doesn't look like this has worked. Any ideas for demonstrating in a PR that a package builds in cross? |
|
I started tracking the dependency PRs in the top comment. Either this PR can stay for tracking only, or we can use it when it's down to changing |
|
What is the difference between the last cygwin pr: #447520 and this? |
This one is specifically for getting a cross-build of nix working. It's a subset of the other one. |
This change is from upstream packaging/.
|
This PR now only contains one small change to nix packaging, which is also in NixOS/nix#14844. It won't build in master until the next (or possibly next-next) staging merge, but it should build in staging after this and the last remaining dependency PR (libidn2) makes it there. |
|
Congratulations! |
Dependency PRs:
cc-wrapper: cc-wrapper: set gl_cv_clean_version_stddef=yes on cygwin #468206Related:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.