libtins: fix build with cmake 4 #450277
Merged
libtins: fix build with cmake 4 #450277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs-ci
bot
added
2.status: merge conflict
Patches CMakeLists.txt and CheckCXXFeatures.cmake to require CMake 3.10 instead of 2.8.x. CMake 4 doesn't support versions older than 3.5, and versions between 3.5-3.10 are deprecated. Upstream PR: mfontanini/libtins#553 Fixes: NixOS#450198 Signed-off-by: Dave Walker <[email protected]>
Daviey
force-pushed
the
fix/libtins-cmake4-build-failure
branch
from
7b85b2c to
d96224c
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Sigmanificient
approved these changes
Oct 9, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
|
leona-ya
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450198
Patches CMakeLists.txt and CheckCXXFeatures.cmake to require CMake 3.10 instead of 2.8.x. CMake 4 doesn't support versions older than 3.5, and versions between 3.5-3.10 are deprecated.
Upstream PR: mfontanini/libtins#553
Tested by building the package on Linux.