Skip to content

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Oct 3, 2025

The previous PR was reverted because it breaks click-repl.
This PR circumvents that problem by removing from python3Packages.celery the functionality that depends on click-repl.
In order still give access to the affected AMQP REPL, we introduce a top-level attribute celery which uses an overridden Python package set. This however violates #421201.
I also don't like the number of packages that have to be rebuilt just to build celery. Maybe we shouldn't add the top-level attribute and let our users override click if they need the AMQP REPL?

fixes #438287
cc @MultisampledNight @caniko @RaitoBezarius @frogamic

This breaks at least:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@dotlambda dotlambda requested a review from mweinelt October 3, 2025 09:58
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 3, 2025
@nix-owners nix-owners bot requested review from NickCao and fabaff October 3, 2025 10:03
@dotlambda dotlambda marked this pull request as draft October 3, 2025 10:08
@dotlambda dotlambda changed the title python3Packages.click: 8.1.8 -> 8.2.1 python3Packages.click: 8.1.8 -> 8.3.0 Oct 3, 2025
@dotlambda dotlambda force-pushed the python3Packages.click branch from e085ddb to 3da480c Compare October 3, 2025 10:24
@caniko

This comment was marked as off-topic.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 3, 2025
@MultisampledNight
Copy link
Member

@caniko would you mind taking the pyproject-nix suggestion to a more sync channel like #python:nixos.org on matrix? not sure how this pull would benefit from the discussion this would spark

@dotlambda dotlambda force-pushed the python3Packages.click branch from a97fbd6 to 6ed3274 Compare October 6, 2025 10:40
@dotlambda
Copy link
Member Author

I also don't like the number of packages that have to be rebuilt just to build celery. Maybe we shouldn't add the top-level attribute and let our users override click if they need the AMQP REPL?

I went for that. We can always add back 44c514f if we need a top-level celery.

@dotlambda dotlambda marked this pull request as ready for review October 6, 2025 14:55
@nix-owners nix-owners bot requested review from antonmosich and mbalatsko October 6, 2025 15:00
@antonmosich
Copy link
Contributor

todoman also encounters the error from test_sane_config when starting the resulting executable with no arguments/subcommand (with my config at least). I don't have the time to fix this right now though, sorry.

@dotlambda
Copy link
Member Author

todoman also encounters the error from test_sane_config when starting the resulting executable with no arguments/subcommand (with my config at least). I don't have the time to fix this right now though, sorry.

In that case let's stick with version 8.2.1 for now.

@dotlambda dotlambda changed the title python3Packages.click: 8.1.8 -> 8.3.0 python3Packages.click: 8.1.8 -> 8.2.1 Oct 7, 2025
@dotlambda dotlambda force-pushed the python3Packages.click branch from 3cb00b8 to 73f9245 Compare October 7, 2025 09:50
@dotlambda dotlambda enabled auto-merge October 7, 2025 09:53
@dotlambda dotlambda disabled auto-merge October 7, 2025 09:54
@dotlambda
Copy link
Member Author

Weirdly, greynoise's tests fail with click 8.2.1 but not 8.3.0.
Honestly, I don't care and I'll merge this anyway if everything else looks good enough.

@dotlambda dotlambda force-pushed the python3Packages.click branch from 73f9245 to 349bee3 Compare October 7, 2025 13:04
@nix-owners nix-owners bot requested a review from winpat October 7, 2025 13:11
@dotlambda dotlambda merged commit 1a4bf1a into NixOS:staging Oct 7, 2025
28 of 32 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Python batch upgrade Oct 7, 2025
@dotlambda dotlambda deleted the python3Packages.click branch October 7, 2025 13:37
GaetanLepage added a commit to GaetanLepage/nixpkgs that referenced this pull request Oct 21, 2025
@dotlambda
Copy link
Member Author

todoman also encounters the error from test_sane_config when starting the resulting executable with no arguments/subcommand (with my config at least). I don't have the time to fix this right now though, sorry.

In that case let's stick with version 8.2.1 for now.

8.3.1 should fix that issue: #454434

GaetanLepage added a commit to GaetanLepage/nixpkgs that referenced this pull request Oct 24, 2025
GaetanLepage added a commit to GaetanLepage/nixpkgs that referenced this pull request Oct 24, 2025
@dotlambda dotlambda mentioned this pull request Oct 25, 2025
3 tasks
github-actions bot pushed a commit to Mic92/nixpkgs that referenced this pull request Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants