-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
python3Packages.click: 8.1.8 -> 8.2.1 #448189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e085ddb to
3da480c
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@caniko would you mind taking the pyproject-nix suggestion to a more sync channel like #python:nixos.org on matrix? not sure how this pull would benefit from the discussion this would spark |
a97fbd6 to
6ed3274
Compare
I went for that. We can always add back 44c514f if we need a top-level celery. |
|
|
In that case let's stick with version 8.2.1 for now. |
3cb00b8 to
73f9245
Compare
|
Weirdly, greynoise's tests fail with click 8.2.1 but not 8.3.0. |
The REPL depends on click-repl, which doesn't support click >= 8.2.0.
The REPL depends on click-repl, which doesn't support click >= 8.2.0.
73f9245 to
349bee3
Compare
8.3.1 should fix that issue: #454434 |
Broken since click was updated to 8.2.1 in NixOS#448189
The previous PR was reverted because it breaks click-repl.
This PR circumvents that problem by removing from
python3Packages.celerythe functionality that depends on click-repl.In order still give access to the affected AMQP REPL, we introduce a top-level attribute
celerywhich uses an overridden Python package set. This however violates #421201.I also don't like the number of packages that have to be rebuilt just to build
celery. Maybe we shouldn't add the top-level attribute and let our users override click if they need the AMQP REPL?fixes #438287
cc @MultisampledNight @caniko @RaitoBezarius @frogamic
This breaks at least:
TypeError: 'Sentinel' object is not iterablepimutils/todoman#596 @leenaars @antonmosichThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.