-
-
Notifications
You must be signed in to change notification settings - Fork 17k
{python3packages.py,}meshlab: 2023.12 -> 2025.07 + use system dependencies , and update dependencies #445078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
7b28d0d
to
0cf289a
Compare
pkgs/by-name/me/meshlab/1617_cmake-use-system-dependencies-install-exports.patch
Show resolved
Hide resolved
part of #445447 |
pkgs/by-name/me/meshlab/1617_cmake-use-system-dependencies-install-exports.patch
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
|
lm.h only contains a deprecation warning now
Co-authored-by: Sandro <[email protected]>
fix meshlab on darwin: ``` [ 47%] Building CXX object src/meshlabplugins/filter_cubization/CMakeFiles/filter_cubization.dir/filter_cubization_autogen/mocs_compilation.cpp.o In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/build/src/meshlabplugins/filter_cubization/filter_cubization_autogen/mocs_compilation.cpp:2: In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/build/src/meshlabplugins/filter_cubization/filter_cubization_autogen/EWIEGA46WW/moc_filter_cubization.cpp:10: In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/build/src/meshlabplugins/filter_cubization/filter_cubization_autogen/EWIEGA46WW/../../../../../../src/meshlabplugins/filter_cubization/filter_cubization.h:28: In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/src/common/../common/plugins/interfaces/filter_plugin.h:29: In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/src/common/../common/plugins/interfaces/../../ml_document/mesh_document.h:27: In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/src/common/../common/plugins/interfaces/../../ml_document/mesh_model.h:26: In file included from /nix/store/18nlfi993h20y6dd1kfg8zm9gaglwygn-glew-2.2.0-dev/include/GL/glew.h:1217: In file included from /nix/store/rhlyld20zdzdi5wghb4b12gw52s9whr9-apple-sdk-11.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenGL.framework/Headers/glu.h:9: /nix/store/zchkzj4md6q4lq09iidcm4c8n7r22k46-libigl-2.6.0/include/igl/OpenGL/gl.h:23:10: fatal error: 'glad/glad.h' file not found 23 | #include <glad/glad.h> | ^~~~~~~~~~~~~ ```
Co-authored-by: Sandro <[email protected]>
- fix CMake exports - add missing library - update to llvm 19 Co-authored-by: Zexin Yuan <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
rebased to fix a conflict in aliases.nix |
Co-authored-by: jopejoe1 <[email protected]>
|
qt applications on drawin include a sandbox profile, so they don't work with sandbox = true And I suspect lib3mf run into OOM error based on the log |
fix #445078
Hi,
This PR update meshlab & python3Packages.pymeshlab from 2023.12 to 2025.07, among other things to fix build with CMake v4.
It also update their dependencies (levmar, lib3mf, tinygltf, vcg, corto, and nexus) and their packaging to use standard CMake exports (ref. cnr-isti-vclab/vcglib#248)
While here, meshlab-unstable is dropped, since it was older than 2025.07, cc. @pca006132
When I started to work on this, I did not see the work from #396295 (merged only 4 days ago), so I tried to merge this work with mine, but a few things might seem odd in the history. cc. @yzx9
I tested that by opening meshlab GUI and loading a mesh (only on linux) and trying a simple mesh decimation from python (linux & darwin):
And, yes,
base_link2.STL
takes less disk space thanbase_link.STL
(a random file from example-robot-data)Things done
passthru.tests
.nixpkgs-review
on this PR. See nixpkgs-review usage../result/bin/
.Add a 👍 reaction to pull requests you find important.