Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stalwart-mail: 0.10.7 -> 0.11.1; stalwart-mail.webadmin: 0.1.20 -> 0.1.21 #371532

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

onny
Copy link
Contributor

@onny onny commented Jan 6, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Shawn8901
Copy link
Contributor

Shawn8901 commented Jan 6, 2025

if i see it correctly our module breaks according https://github.com/stalwartlabs/mail-server/blob/v0.11.1/UPGRADING.md . the spam filter and webadmin has moved in configuration.

@oddlama
Copy link
Contributor

oddlama commented Jan 7, 2025

Yes this will break the module, we have to move those keys. Also there might be a typo in their updating.md, I'm not sure why the new option should be called spam-filter.webadmin. From what I can see in their code, it should be resource.webadmin which makes more sense.

@Shawn8901
Copy link
Contributor

Shawn8901 commented Jan 7, 2025

fyi i created an issue upstream for that stalwartlabs/mail-server#1061 to clarify

@Shawn8901
Copy link
Contributor

fyi i created an issue upstream for that stalwartlabs/mail-server#1061 to clarify

fyi: issue was closed with an update stalwartlabs/mail-server@fcbf58f
So webadmin.resource is correct.

@Pandapip1
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371532

@Pandapip1
Copy link
Contributor

Pandapip1 commented Jan 8, 2025

Uh, that doesn't seem right. 0 changed packages? I'm opening a bug report.

@dantefromhell
Copy link
Contributor

The build fails for me with:

    Finished `release` profile [optimized] target(s) in 36m 07s
Executing cargoInstallPostBuildHook
Finished cargoInstallPostBuildHook
Finished cargoBuildHook
buildPhase completed in 36 minutes 10 seconds
Running phase: installPhase
@nix { "action": "setPhase", "phase": "installPhase" }
Executing cargoInstallHook
cp: cannot stat 'resources/config/spamfilter': No such file or directory

The resources/config/spamfilter folder has been removed upstream as it got ported from sieve to rust, see https://github.com/stalwartlabs/mail-server/commits/main/resources/config

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 9, 2025
@onny onny force-pushed the stalwart-mail-update3 branch 2 times, most recently from de2d55b to fd71c4f Compare January 9, 2025 10:00
@onny onny force-pushed the stalwart-mail-update3 branch from fd71c4f to 53bdb2b Compare January 9, 2025 10:05
);
in
{
spam-filter = lib.mkDefault "file://${cfg.package}/etc/stalwart/spamfilter.toml";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be swapped, i.e. spam-filter.resource not resource.spam-filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants