-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stalwart-mail: 0.10.7 -> 0.11.1; stalwart-mail.webadmin: 0.1.20 -> 0.1.21 #371532
base: master
Are you sure you want to change the base?
Conversation
if i see it correctly our module breaks according https://github.com/stalwartlabs/mail-server/blob/v0.11.1/UPGRADING.md . the spam filter and webadmin has moved in configuration. |
Yes this will break the module, we have to move those keys. Also there might be a typo in their updating.md, I'm not sure why the new option should be called |
fyi i created an issue upstream for that stalwartlabs/mail-server#1061 to clarify |
fyi: issue was closed with an update stalwartlabs/mail-server@fcbf58f |
|
Uh, that doesn't seem right. 0 changed packages? I'm opening a bug report. |
The build fails for me with:
The |
de2d55b
to
fd71c4f
Compare
fd71c4f
to
53bdb2b
Compare
); | ||
in | ||
{ | ||
spam-filter = lib.mkDefault "file://${cfg.package}/etc/stalwart/spamfilter.toml"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be swapped, i.e. spam-filter.resource
not resource.spam-filter
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.