workflows/eval: add eval summary before requesting reviewers #371528
Merged
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure that the eval summary is still set as commit status, even when the review requests fail due to too many reviewers.
github-actions
bot
added
6.topic: policy discussion
6.topic: continuous integration
nix-owners
bot
requested review from
Mic92,
risicle,
LeSuisse,
zowoq,
mweinelt and
azuwis
github-actions
bot
added
10.rebuild-darwin: 0
Draft
7 tasks
|
Will this prevent CI from showing up as failed when this happens? |
|
No, the job is showing as failed on purpose until we implement something better for that - or decide that silently non-failing is the right thing to do. Still working on that. |
infinisil
approved these changes
Jan 6, 2025
|
I think it’s unfortunate that it makes it look like there’s an eval problem with the PR on every treewide. I would prefer the GitHub grey status that ofborg used to use for this. (It also means I get an email for every merge into |
100%, so would I. Unfortunately - not that easy to do :D |
|
Well, I’d still take green over red if those are the two choices, because of the email thing :) |
|
How about continue-on-error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure that the eval summary is still set as commit status, even when the review requests fail due to too many reviewers.
Noticed by @emilazy in #370995 (comment).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.