Adding stl-thumb derivation #370942
Adding stl-thumb derivation #370942
Conversation
github-actions
bot
added
8.has: maintainer-list (update)
github-actions
bot
added
10.rebuild-darwin: 0
There was a problem hiding this comment.
-
For consistency with other packages, consider running
nix-shell -p nixpkgs-hammering --run "nixpkgs-hammer stl-thumb"in the root Nixpkgs directory, and make the edits the program tells you to. -
Please review the Commit Conventions and squash your commits appropriately. There should be two commits total:
maintainers: add SyntaxualSugarstl-thumb: init at 0.5.0
| @@ -0,0 +1,62 @@ | |||
| { | |||
| lib, | |||
| pkgs, | |||
There was a problem hiding this comment.
| pkgs, |
We don't call pkgs inside Nixpkgs.
| { | ||
| lib, | ||
| pkgs, | ||
| stdenv, |
There was a problem hiding this comment.
| stdenv, |
Please remove all unused inputs.
| --add-needed ${libGL}/lib/libEGL.so \ | ||
| $out/bin/stl-thumb | ||
| ''; | ||
| meta = with lib; { |
There was a problem hiding this comment.
| meta = with lib; { | |
| meta = { |
Nested with; expressions is an anti-pattern.
| src = fetchFromGitHub { | ||
| owner = "unlimitedbacon"; | ||
| repo = pname; | ||
| rev = "6bc90573b2cddda3f8916b2716898298475406c0"; |
There was a problem hiding this comment.
| rev = "6bc90573b2cddda3f8916b2716898298475406c0"; | |
| tag = "v${version}"; |
|
|
||
| src = fetchFromGitHub { | ||
| owner = "unlimitedbacon"; | ||
| repo = pname; |
There was a problem hiding this comment.
| repo = pname; | |
| repo = "stl-thumb"; |
Avoid interpolating pname.
| }: | ||
| pkgs.rustPlatform.buildRustPackage rec { | ||
| pname = "stl-thumb"; | ||
| version = "0.5.0-6bc9057"; |
There was a problem hiding this comment.
| version = "0.5.0-6bc9057"; | |
| version = "0.5.0"; |
| sha256 = "sha256-G5zk1FR18rhWdC1S1cGOcsAHRpq03A7+ivNs4sUpl54="; | ||
| }; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Please add a comment explaining why we're skipping tests.
There was a problem hiding this comment.
There are 3 tests in the project and all of them need an xdg runtime configured. I haven't been able to figure out how to get it working within the check phase.
There was a problem hiding this comment.
If they only need a dir create a dir with mktemp -d then and pass it to a environment variable in preCheck
| fontconfig | ||
| libX11 | ||
| ]; | ||
| propagatedBuildInputs = [ |
There was a problem hiding this comment.
Why are we propagating these?
There was a problem hiding this comment.
I believe I was propagating them while trying to get the tests to work. For my education, what is the downside of propagating inputs?
Thank you for all of the feedback! I will clean up the changes and come back with a new pull request. |
|
There's... really no need. Just force-push this one. It's best if we don't lose the review history. |
SyntaxualSugar
force-pushed
the
master
branch
3 times, most recently
from
c5966af to
419da30
Compare
github-actions
bot
added
10.rebuild-linux: 0
|
the maintainers commit has a weird diff |
|
stl-thumb is a thumbnail generator for STL and OBJ files (helpful for file managers). It is tested against Gnome and KDE (KDE with an extra plugin needed), and Windows, but any file manager should work.
stl-thumb
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.