Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/wakapi: fix running under sqlite3; add stateDir; add sqlite test case #370497

Merged
merged 2 commits into from
Jan 16, 2025
Merged

nixos/wakapi: fix running under sqlite3; add stateDir; add sqlite test case #370497

merged 2 commits into from
Jan 16, 2025

Conversation

NotAShelf
Copy link
Member

  • nixos/wakapi: add stateDir and set service WorkingDirectory
  • tests/wakapi: switch to subest; add sqlite3 case

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 3, 2025
@NotAShelf NotAShelf requested a review from isabelroses January 3, 2025 05:25
@NotAShelf
nixos/wakapi: add stateDir and set service WorkingDirectory
3204e04 
For some reason, StateDirectory does not work very well with the sqlite format.
This acts as a workaround of such, and allows the service to alternatively work
in an alternative, user-created directory if the issue does arise again.

See muety/wakapi#731 for context and
motivations for this change.
@NotAShelf
tests/wakapi: switch to subest; add sqlite3 case
fde8246
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 3, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 4, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 4, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370497

x86_64-linux

✅ 1 test built:
  • nixosTests.wakapi

@NotAShelf NotAShelf added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 5, 2025
@wolfgangwalther wolfgangwalther merged commit 459db35 into NixOS:master Jan 16, 2025
27 of 28 checks passed
@NotAShelf NotAShelf deleted the wakapi-sqlite-fix branch January 17, 2025 08:51
dustypomerleau pushed a commit to dustypomerleau/nixpkgs that referenced this pull request Jan 20, 2025
@wolfgangwalther @dustypomerleau
nixos/wakapi: fix running under sqlite3; add stateDir; add sqlite tes…
b90f014 
…t case (NixOS#370497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelroses isabelroses isabelroses approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NotAShelf @lucasew @isabelroses @wolfgangwalther @wegank