Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby-packages.prism: 0.24.0 -> 1.3.0 (#369508) #370214

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

pcboy
Copy link
Contributor

@pcboy pcboy commented Jan 2, 2025

Bumping rubyPackages.prism to latest version 1.3.0 seems to fix compilation.

#369508

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@pcboy
Copy link
Contributor Author

pcboy commented Jan 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370214


x86_64-linux

✅ 8 packages built:
  • ruby-lsp (rubyPackages.ruby-lsp ,rubyPackages_3_3.ruby-lsp)
  • rubyPackages.prism (rubyPackages_3_3.prism)
  • rubyPackages_3_1.prism
  • rubyPackages_3_1.ruby-lsp
  • rubyPackages_3_2.prism
  • rubyPackages_3_2.ruby-lsp
  • rubyPackages_3_4.prism
  • rubyPackages_3_4.ruby-lsp

@pcboy pcboy marked this pull request as ready for review January 2, 2025 12:36
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370214


x86_64-linux

✅ 8 packages built:
  • ruby-lsp (rubyPackages.ruby-lsp ,rubyPackages_3_3.ruby-lsp)
  • rubyPackages.prism (rubyPackages_3_3.prism)
  • rubyPackages_3_1.prism
  • rubyPackages_3_1.ruby-lsp
  • rubyPackages_3_2.prism
  • rubyPackages_3_2.ruby-lsp
  • rubyPackages_3_4.prism
  • rubyPackages_3_4.ruby-lsp

x86_64-darwin

✅ 8 packages built:
  • ruby-lsp (rubyPackages.ruby-lsp ,rubyPackages_3_3.ruby-lsp)
  • rubyPackages.prism (rubyPackages_3_3.prism)
  • rubyPackages_3_1.prism
  • rubyPackages_3_1.ruby-lsp
  • rubyPackages_3_2.prism
  • rubyPackages_3_2.ruby-lsp
  • rubyPackages_3_4.prism
  • rubyPackages_3_4.ruby-lsp

aarch64-darwin

✅ 8 packages built:
  • ruby-lsp (rubyPackages.ruby-lsp ,rubyPackages_3_3.ruby-lsp)
  • rubyPackages.prism (rubyPackages_3_3.prism)
  • rubyPackages_3_1.prism
  • rubyPackages_3_1.ruby-lsp
  • rubyPackages_3_2.prism
  • rubyPackages_3_2.ruby-lsp
  • rubyPackages_3_4.prism
  • rubyPackages_3_4.ruby-lsp

@GaetanLepage GaetanLepage merged commit 4448dfa into NixOS:master Jan 2, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants