Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zfs-replication: add --verbose to command line arguments #370150

Merged
merged 2 commits into from
Jan 2, 2025
Merged

nixos/zfs-replication: add --verbose to command line arguments #370150

merged 2 commits into from
Jan 2, 2025

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jan 2, 2025 •
edited
Loading

Things done

  • nixos/zfs-replication: use expanded arguments for clarity
  • nixos/zfs-replication: add --verbose to command line arguments

cc @alunduil

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 2, 2025
@GaetanLepage GaetanLepage added backport release-24.11 Backport PR automatically and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 2, 2025
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 2, 2025
@GaetanLepage GaetanLepage merged commit 671f385 into NixOS:master Jan 2, 2025
33 of 34 checks passed
@GaetanLepage GaetanLepage deleted the zfs-replication branch January 2, 2025 10:54
@nix-backports
Copy link

nix-backports bot commented Jan 2, 2025

Successfully created backport PR for release-24.11:

@nix-backports nix-backports bot mentioned this pull request Jan 2, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alunduil alunduil alunduil approved these changes

@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaetanLepage @alunduil