Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elf2uf2-rs: 2.0.0 -> 2.1.1 #368805

Merged
merged 4 commits into from
Jan 4, 2025
Merged

elf2uf2-rs: 2.0.0 -> 2.1.1 #368805

merged 4 commits into from
Jan 4, 2025
+38 −37

Conversation

moni-dz
Copy link
Contributor

@moni-dz moni-dz commented Dec 28, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@moni-dz moni-dz added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 28, 2024
@ofborg ofborg bot requested a review from polygon December 28, 2024 15:42
donovanglover
donovanglover reviewed Jan 1, 2025
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixfmt and by-name changes should be separate commits so the diff is easier to read

@moni-dz moni-dz force-pushed the moni/poopomursorv branch from 1383e34 to 284eaa5 Compare January 1, 2025 10:59
@moni-dz moni-dz requested a review from donovanglover January 1, 2025 11:00
@moni-dz moni-dz force-pushed the moni/poopomursorv branch from 284eaa5 to 454dbad Compare January 1, 2025 11:06
@moni-dz moni-dz force-pushed the moni/poopomursorv branch from 454dbad to 963ab09 Compare January 1, 2025 11:20
@moni-dz moni-dz requested a review from donovanglover January 1, 2025 11:22
donovanglover
donovanglover approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM waiting for ofborg

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 2, 2025
@donovanglover
Copy link
Member

@ofborg build elf2uf2-rs

@donovanglover
Copy link
Member

Built on x86_64-linux with nix build github:moni-dz/nixpkgs/moni/poopomursorv#elf2uf2-rs

@donovanglover donovanglover merged commit d84661f into NixOS:master Jan 4, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donovanglover donovanglover donovanglover approved these changes

@polygon polygon Awaiting requested review from polygon

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moni-dz @donovanglover @wegank