nixos/swapspace: add installWrapper option #368539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
github-actions
bot
added
10.rebuild-darwin: 0
Luflosi
reviewed
Dec 27, 2024
Signed-off-by: phanirithvij <[email protected]> Co-authored-by: Luflosi <[email protected]>
phanirithvij
force-pushed
the
swapspace-wrapper
branch
from
ef8d883 to
64b06b0
Compare
|
I've taken the liberty to refactor swapspace package derivation. It builds with the same hash as before. |
|
@ofborg build nixosTests.swapspace |
phanirithvij
added
12.approvals: 1
wegank
removed
the
12.approved-by: package-maintainer
|
@StrongSand94191 can you try it out? one way to do it is using https://discourse.nixos.org/t/tips-tricks-for-nixos-desktop/28488/14 |
GaetanLepage
reviewed
Jan 1, 2025
sorry, i am not great at this and i couldn't get the flake to work |
Signed-off-by: phanirithvij <[email protected]> Update pkgs/by-name/sw/swapspace/package.nix Co-authored-by: Gaétan Lepage <[email protected]>
phanirithvij
force-pushed
the
swapspace-wrapper
branch
from
cb578ee to
c783fed
Compare
|
@StrongSand94191 you can wait till this pr lands on nixos-unstable or backported to 24.11 |
phanirithvij
added
12.approvals: 2
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #368492
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.