Skip to content

stdenv.mkDerivation: inputDerivation: fix for __structuredAttrs = true #368226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
infinisil merged 1 commit into from
Dec 31, 2024
Merged

stdenv.mkDerivation: inputDerivation: fix for __structuredAttrs = true #368226

infinisil merged 1 commit into from
Dec 31, 2024

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Dec 26, 2024 •
edited
Loading

This PR makes <drv>.inputDerivaiton evaluate without warnings messages regarding the outputChecks.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 26, 2024
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Dec 26, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368226

x86_64-linux

@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Dec 26, 2024

@ofborg build tests.overriding
@ofborg build tests.stdenv
@ofborg build tests.stdenv-inputs

@ShamrockLee ShamrockLee marked this pull request as ready for review December 26, 2024 07:05
wolfgangwalther
wolfgangwalther approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 26, 2024
@ShamrockLee ShamrockLee requested a review from alyssais December 26, 2024 16:30
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Dec 26, 2024

OfBorg failed to build tests.stdenv on x86_64-darwin due to time out after 3600 seconds, which is quite common among the OfBorg Darwin builders and a long build like this.

@philiptaron
Copy link
Contributor

philiptaron commented Dec 26, 2024

Basically flat on performance.

@alyssais alyssais requested a review from infinisil December 31, 2024 15:55
@infinisil infinisil merged commit 30086ec into NixOS:master Dec 31, 2024
80 of 83 checks passed
infinisil added a commit to tweag/nixpkgs that referenced this pull request Nov 21, 2025
@infinisil
stdenv: Fix inputDerivation for __structuredAttrs (again?)
d2cc412 
Supposedly NixOS#368226 fixed it, but
either nobody actually tested it or older Nix versions were fine, but
all currently available Nix versions, including 2.24 and 2.32 complain
about it:

    building '/nix/store/9n4hwzk8s74n6cq8dlxa4qas9jchsbgc-inputDerivation.drv'...
    error: output '/nix/store/l3gmc01pwa42rzq9riv8wm3skzkm144r-inputDerivation' is not allowed to refer to the following paths:
             /nix/store/k5z8rkvj1fn1nrf05l5a86aflc5s1p6m-stdenv-linux
             /nix/store/l3gmc01pwa42rzq9riv8wm3skzkm144r-inputDerivation
             /nix/store/l622p70vy8k5sh7y5wizi5f2mic6ynpg-source-stdenv.sh
             /nix/store/qsydfxm1vq6q9jac2kq3r8kn0xdmsldf-bash-5.3p3
             /nix/store/shkw4qm9qcw5sc5n1k5jznc83ny02r39-default-builder.sh

This commit fixes it (again?) and adds a regression test
@infinisil infinisil mentioned this pull request Nov 21, 2025
Closed
13 tasks
@infinisil
Copy link
Member

infinisil commented Nov 21, 2025

Oddly enough, inputDerivation with __structuredAttrs appears broken to me even with this PR. Here's a fix: #463882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@infinisil infinisil infinisil approved these changes

@Artturin Artturin Awaiting requested review from Artturin

@emilazy emilazy Awaiting requested review from emilazy

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@philiptaron philiptaron Awaiting requested review from philiptaron

@reckenrode reckenrode Awaiting requested review from reckenrode

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

@alyssais alyssais Awaiting requested review from alyssais

Assignees

No one assigned

Labels

6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShamrockLee @philiptaron @infinisil @wolfgangwalther @wegank