Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.virtual-glob: init at 0.2.0 #367475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

python312Packages.virtual-glob: init at 0.2.0 #367475

wants to merge 1 commit into from
+46 −0

Conversation

poperigby
Copy link
Contributor

Added virtual_glob.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium December 22, 2024 22:03
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Dec 23, 2024
zimeg
zimeg reviewed Dec 24, 2024
View reviewed changes
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 left a few comments of (imo) non-blocking changes, but the commit message might need to be changed to "virtual-glob: init at 0.2.0" too!

pkgs/development/python-modules/virtual-glob/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@poperigby
Copy link
Contributor Author

👋 left a few comments of (imo) non-blocking changes, but the commit message might need to be changed to "virtual-glob: init at 0.2.0" too!

Yeah, not sure why I did that. I think I was following someone else that did it wrong haha.

@poperigby poperigby changed the title init: virtual-glob 0.2.0 virtual-glob: init at 0.2.0 Dec 24, 2024
@zimeg
Copy link
Member

zimeg commented Dec 24, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367475

aarch64-darwin

✅ 4 packages built:
  • python312Packages.virtual-glob
  • python312Packages.virtual-glob.dist
  • python313Packages.virtual-glob
  • python313Packages.virtual-glob.dist

@zimeg
Copy link
Member

zimeg commented Dec 24, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367475

x86_64-linux

✅ 4 packages built:
  • python312Packages.virtual-glob
  • python312Packages.virtual-glob.dist
  • python313Packages.virtual-glob
  • python313Packages.virtual-glob.dist

zimeg
zimeg approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as shown in the package README when testing! thanks for making a few changes 🎉

i don't think pythonOlder is needed since python <3.8 reached EOL, but i'm not certain about this 👀 🐍

pluiedev
pluiedev suggested changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR & commit title should be changed to python312Packages.virtual-glob: init at 0.2.0 to signify that it is a Python package (helps CI too!)

pkgs/development/python-modules/virtual-glob/default.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 26, 2024
@poperigby poperigby changed the title virtual-glob: init at 0.2.0 python312Packages.virtual-glob: init at 0.2.0 Dec 28, 2024
@poperigby poperigby requested a review from pluiedev December 28, 2024 05:35
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 29, 2024
@poperigby poperigby requested a review from pluiedev January 1, 2025 06:10
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pluiedev pluiedev pluiedev approved these changes

@zimeg zimeg zimeg approved these changes

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poperigby @zimeg @pluiedev @wegank