Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java-service-wrapper: make deterministic, do some cleanup #295154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Mar 11, 2024

Description of changes

Tracking issue: #278518

This small PR adds stripJavaArchivesHook to the nativeBuildInputs of the java-service-wrapper package to make it deterministic.

It also does some minor cleanup:

  • Use finalAttrs instead of rec
  • change the deprecated --replace flag to --replace-fail, which can't fail silently.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from suhr March 11, 2024 23:57
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 11, 2024
@TomaSajt TomaSajt marked this pull request as draft March 12, 2024 01:43
@TomaSajt TomaSajt force-pushed the java-service-wrapper branch from 7f06c29 to 0e3e2e0 Compare March 19, 2024 07:13
@TomaSajt TomaSajt changed the title java-service-wrapper: make deterministic, use --replace-fail java-service-wrapper: make deterministic, do some cleanup Mar 19, 2024
@TomaSajt TomaSajt marked this pull request as ready for review March 19, 2024 07:21
@TomaSajt TomaSajt force-pushed the java-service-wrapper branch from 0e3e2e0 to 5be4897 Compare June 27, 2024 13:52
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
@TomaSajt TomaSajt force-pushed the java-service-wrapper branch from 5be4897 to c06c1d7 Compare January 4, 2025 23:28
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 4, 2025
@TomaSajt TomaSajt force-pushed the java-service-wrapper branch from c06c1d7 to 960c4a7 Compare January 4, 2025 23:30
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants