Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amdvlk: 2022.Q4.4 → 2023.Q1.2 #216465

Merged
merged 1 commit into from
Feb 21, 2023
Merged

amdvlk: 2022.Q4.4 → 2023.Q1.2 #216465

merged 1 commit into from
Feb 21, 2023

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Feb 15, 2023 •
edited
Loading

Release: https://github.com/GPUOpen-Drivers/AMDVLK/releases/tag/v-2023.Q1.1

Description of changes

Fingers crossed this helps with #216294 This did not fix this 32-bit issue, but it's still a valid update.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@toastal toastal requested a review from Flakebi February 15, 2023 10:26
@andresilva
Copy link
Member

I tested this locally yesterday and unfortunately it didn't fix #216294 😞.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 15, 2023
Flakebi
Flakebi approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, tested vulkaninfo and vkcube (in #200532).

@toastal
Copy link
Contributor Author

toastal commented Feb 15, 2023

Hmm. I checked, but I guess I missed that the bot already opened the upgrade. I wanted to test it out anyhow.

@ofborg ofborg bot requested a review from Flakebi February 17, 2023 12:45
@toastal toastal changed the title amdvlk: 2022.Q4.4 → 2023.Q1.1 amdvlk: 2022.Q4.4 → 2023.Q1.2 Feb 19, 2023
@toastal toastal requested a review from andresilva February 21, 2023 05:04
@toastal
Copy link
Contributor Author

toastal commented Feb 21, 2023

2023.Q1.2 is tagged

@andresilva
Copy link
Member

Tested vulkaninfo and vkcube on both the 64 and 32 bit package. I'm going to go ahead and merge this.

@andresilva andresilva merged commit a4679a5 into NixOS:master Feb 21, 2023
@toastal toastal deleted the amdvlk-2023.Q1.1 branch February 21, 2023 16:16
@toastal toastal restored the amdvlk-2023.Q1.1 branch June 8, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresilva andresilva andresilva approved these changes

@Flakebi Flakebi Awaiting requested review from Flakebi

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toastal @andresilva @Flakebi