Skip to content

Conversation

@icewind1991
Copy link
Contributor

Description of changes

Applies an upstream patch to fix building datasets with dill 0.3.6 which broke with #198883

Build failure discovered when trying to build openai-whisper, with the patch applied it build correctly and works as expected.
While I've build the other dependents, I've not tested the functionality of them

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 15, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 15, 2022
@tjni
Copy link
Contributor

tjni commented Nov 15, 2022

Thank you for doing this, and I'm sorry for the inconvenience!

This duplicates #201298, so merging either one would work. As requested, I'm adding passthru tests to dill that includes this package: #201356.

@icewind1991
Copy link
Contributor Author

Missed that one when trying to find an existing PR, closing this one in favor of #201298

@icewind1991 icewind1991 deleted the python-datasets-dill-0.3.6 branch November 15, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants