ppsspp: add SDL and headless #186441
Merged
ppsspp: add SDL and headless #186441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
| ppsspp-sdl-wayland = callPackage ../applications/emulators/ppsspp { | ||
| pname = "ppsspp-sdl-wayland"; | ||
| forceWayland = true; | ||
| enableVulkan = false; # https://github.com/hrydgard/ppsspp/issues/13845 |
There was a problem hiding this comment.
It is preferrable to put such a documentation inside the expression.
AndersonTorres
suggested changes
Aug 14, 2022
ofborg
bot
added
the
2.status: merge conflict
AndersonTorres
suggested changes
Aug 14, 2022
jian-lin
requested changes
Aug 14, 2022
There was a problem hiding this comment.
The relations between newly added parameters (enableVulkan, enableHeadless and forceWayland) are a bit confusing, could you try to:
- remove uneeded ones, e.g. removing
enableHeadlessand enabling it if possible - and add
assertto make sure these arguments are valid?
ofborg
bot
removed
the
2.status: merge conflict
Change the default ppsspp package to SDL frontend, as it supports vulkan, and is allowed to build the headless binary together.
AndersonTorres
suggested changes
Aug 15, 2022
| mkdir -p $out/share/{applications,ppsspp} | ||
| '' + (if enableQt then '' | ||
| install -Dm555 PPSSPPQt $out/bin/ppsspp | ||
| wrapProgram $out/bin/ppsspp \ |
There was a problem hiding this comment.
What are the parameters of this wrapping?
There was a problem hiding this comment.
In case enableVulkan is overridden to be true, it would be wrapped with --prefix LD_LIBRARY_PATH : ${vulkanPath}. This should allow the Qt front end to detect Vulkan, though not able to use it for now.
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default ppsspp package to SDL front end, as it supports
Vulkan, and is allowed to build the headless binary together.
Description of changes
New packages
ppsspp-sdlppsspp-sdl-waylandPackages changed
ppssppnow uses SDL front end, includes the headless binary, and supports Vulkanppssppwith Qt front end is renamed toppsspp-qtAdditional notes
ppsspp-sdl-wayland. See [Wayland] Blank window with Vulkan backend hrydgard/ppsspp#13845Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes