Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg_3: drop #163509

Merged
merged 2 commits into from
Mar 27, 2022
Merged

ffmpeg_3: drop #163509

merged 2 commits into from
Mar 27, 2022

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Mar 9, 2022

Description of changes

#120705
#121212

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Mar 9, 2022
@ofborg ofborg bot requested review from puffnfresh and vojta001 March 9, 2022 22:00
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 9, 2022
@ajs124 ajs124 marked this pull request as ready for review March 24, 2022 00:02
@ajs124 ajs124 requested a review from dasJ March 24, 2022 00:09
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 24, 2022
@dasJ
Copy link
Member

dasJ commented Mar 24, 2022

Feels like early ZHF ;)

@SuperSandro2000 SuperSandro2000 merged commit 5c1f8cd into master Mar 27, 2022
@SuperSandro2000 SuperSandro2000 deleted the drop/ffmpeg_3 branch March 27, 2022 10:52
@SuperSandro2000 SuperSandro2000 mentioned this pull request Mar 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puffnfresh puffnfresh Awaiting requested review from puffnfresh

@vojta001 vojta001 Awaiting requested review from vojta001

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
Picking up garbage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajs124 @dasJ @SuperSandro2000