Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdrPlugins.vaapidevice: ffmpeg_3 -> ffmpeg #142141

Merged
merged 1 commit into from
Nov 14, 2021
Merged

vdrPlugins.vaapidevice: ffmpeg_3 -> ffmpeg #142141

merged 1 commit into from
Nov 14, 2021

Conversation

wackbyte
Copy link
Contributor

It seems to build properly with no changes.
Inspecting the logs further reveals that it built with only deprecation warnings.

Motivation for this change

#120705

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wackbyte
vdrPlugins.vaapidevice: ffmpeg_3 -> ffmpeg
6c173bb 
Luckily, it seems to build properly with no changes.
Inspecting the logs further reveals that it built with only deprecation warnings.
@ofborg ofborg bot requested a review from ck3d October 18, 2021 21:42
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 18, 2021
@dotlambda dotlambda mentioned this pull request Oct 18, 2021
Closed
@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 142141 run on x86_64-linux 1

1 package built:
  • vdrPlugins.vaapidevice

@thiagokokada thiagokokada merged commit dd9763e into NixOS:master Nov 14, 2021
@wackbyte wackbyte deleted the vdr-vaapidevice-ffmpeg branch November 14, 2021 19:52
@wackbyte wackbyte restored the vdr-vaapidevice-ffmpeg branch December 8, 2021 00:04
@wackbyte wackbyte deleted the vdr-vaapidevice-ffmpeg branch December 8, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@ck3d ck3d ck3d approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wackbyte @thiagokokada @ck3d