Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ha-ffmpeg: does not depend on ffmpeg_3 #121187

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Apr 29, 2021

The path to the binary is specified in the configuration:
https://www.home-assistant.io/integrations/ffmpeg#ffmpeg_bin

Motivation for this change

#120705

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 29, 2021

Result of nixpkgs-review pr 121187 at 0897eb3 run on aarch64-linux 1

3 packages built successfully:
  • home-assistant
  • python38Packages.ha-ffmpeg
  • python39Packages.ha-ffmpeg
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/ha-ffmpeg/default.nix:22:0:

       |
    22 |     description = "Library for home-assistant to handle ffmpeg";
       | ^
    

Result of nixpkgs-review pr 121187 at 0897eb3 run on x86_64-linux 1

3 packages built successfully:
  • home-assistant
  • python38Packages.ha-ffmpeg
  • python39Packages.ha-ffmpeg
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/ha-ffmpeg/default.nix:22:0:

       |
    22 |     description = "Library for home-assistant to handle ffmpeg";
       | ^
    

@mweinelt mweinelt merged commit 09f9d78 into NixOS:master Apr 29, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 29, 2021
@dotlambda dotlambda deleted the ha-ffmpeg branch April 30, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants