Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carla: remove ffmpeg as dependency #121076

Merged
merged 1 commit into from
Apr 29, 2021
Merged

carla: remove ffmpeg as dependency #121076

merged 1 commit into from
Apr 29, 2021

Conversation

minijackson
Copy link
Member

Motivation for this change

FFmpeg is not strictly needed and used in legacy code. Carla also
requires an old vulnerable version of FFmpeg.

Discussion upstream here: falkTX/Carla#1403

Migrating from ffmpeg_3 issue here: #120705

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@minijackson
carla: remove ffmpeg as dependency
6189cc8 
FFmpeg is not strictly needed and used in legacy code. Carla also
requires an old vulnerable version of FFmpeg
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 28, 2021
wamserma
wamserma approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@wamserma wamserma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-shell -p nixpkgs-review --run "nixpkgs-review pr 121076" was successful and the linked comments also support this change

@SuperSandro2000 SuperSandro2000 merged commit 01d55fc into NixOS:master Apr 29, 2021
@minijackson minijackson deleted the carla-remove-ffmpeg branch April 29, 2021 07:33
@dotlambda dotlambda mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minijackson @wamserma @SuperSandro2000