Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qmmp: switch from ffmpeg_3 to ffmpeg #120771

Merged
merged 4 commits into from
Apr 27, 2021
Merged

qmmp: switch from ffmpeg_3 to ffmpeg #120771

merged 4 commits into from
Apr 27, 2021

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

Ref. issue #120705.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bjornfor bjornfor mentioned this pull request Apr 26, 2021
Closed
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 26, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 26, 2021 •
edited
Loading

Result of nixpkgs-review pr 120771 at 27e8279 run on x86_64-linux 1

1 package built successfully:
  • qmmp
1 suggestion:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/audio/qmmp/default.nix:57:5:

       |
57 |     license = licenses.gpl2;
   |     ^

Result of nixpkgs-review pr 120771 at 27e8279 run on aarch64-linux 1

1 package built successfully:
  • qmmp

dotlambda
dotlambda requested changes Apr 26, 2021
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License should be gpl2Plus.

@bjornfor
Copy link
Contributor Author

License should be gpl2Plus.

Done.

SuperSandro2000
SuperSandro2000 reviewed Apr 27, 2021
View reviewed changes
pkgs/applications/audio/qmmp/default.nix Outdated
@@ -54,7 +54,7 @@ mkDerivation rec {
meta = with lib; {
description = "Qt-based audio player that looks like Winamp";
homepage = "http://qmmp.ylsoftware.com/";
license = licenses.gpl2;
license = licenses.gpl2Plus;
platforms = platforms.linux;
maintainers = [ maintainers.bjornfor ];
repositories.svn = "http://qmmp.googlecode.com/svn/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL returns 404.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@SuperSandro2000 SuperSandro2000 merged commit 8b6a8e4 into NixOS:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@dotlambda dotlambda dotlambda requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjornfor @r-rmcgibbo @dotlambda @SuperSandro2000